-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.4] backport: Wait for containerd installation in GCE scripts #6553
Conversation
/cc @SergeyKanzhelev |
Hi @bobbypage. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Build succeeded.
|
could you re-based on the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change lgtm
thank you for making a backport
Prior to running the `kube-node-installation.service`, the containerd installation should be complete as the k8s installation may have dependencies on containerd and related binaries (e.g ctr). Add wants/after systemd directives to ensure `kube-node-installation.service` will only start after containerd installation completes. Signed-off-by: David Porter <[email protected]>
5f33a51
to
6d93874
Compare
Thanks for taking a look, rebased! |
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ok-to-test |
back on the 1.4 timeline the e2e node prow buckets ran from containerd/cri or from k/k |
This cherrypicks #6544 to
release-1.4
branch. This will only affect k/k CI and e2e tests.Prior to running the
kube-node-installation.service
, the containerdinstallation should be complete as the k8s installation may have
dependencies on containerd and related binaries (e.g ctr). Add
wants/after systemd directives to ensure
kube-node-installation.service
will only start after containerdinstallation completes.
Signed-off-by: David Porter [email protected]