Not sure if there's gonna be more 1.4.x release, but if so, we may as well have the branch up to date

Just FYI, something has gotten stale on release/1.4 where the ginko/CRI tests no longer work. I tried to dig into it a bit last week and dead ended after finding the same commits are being used elsewhere. Might need someone more versed in the critest project to help figure it out.

Ah, I see it indeed;

ginkgo run failed
    default:   flag provided but not defined: -skipMeasurements

It guess it goes wrong here (as no version is specified);

Possibly something like 6b0e241 would be needed (trying to cherry-pick it, but doesn't apply clean)

Build succeeded.

• containerd-build-arm64 : NODE_FAILURE in 0s (non-voting)

Pushed a commit, roughly based on 6b0e241 (#6328); let's see if that fixes it.

Did a quick check, and ginkgo 1.16.5 looks to still have that flag;

go install github.com/onsi/ginkgo/[email protected]
#...

ginkgo --help | grep skipMeasurements
  -skipMeasurements

Build succeeded.

• containerd-build-arm64 : NODE_FAILURE in 0s (non-voting)

Hmm... now it looks to be failing in vagrant provisioning

==> default: Running provisioner: install-cri-tools (shell)...
    default: Running: inline script
    default: + /root/go/src/github.com/containerd/containerd/script/setup/install-critools
    default: go: modules disabled by GO111MODULE=off; see 'go help modules'
The SSH command responded with a non-zero exit status. Vagrant
assumes that this means the command failed. The output for this command
should be in the log above. Please read the output to determine what

Arf.. by bad; I used GO111MODULES (plural) instead of singular 🤦 - fixed

Build succeeded.

• containerd-build-arm64 : NODE_FAILURE in 0s (non-voting)

nice work; I had looked at that commit too; not sure how I decided that wasn't the source of the issue! :) I did see that recent ginko no longer has that flag but probably got distracted with other work before trying to resolve what version we were using!