[release/1.5] go.mod: Bump hcsshim to v0.8.23#6231
[release/1.5] go.mod: Bump hcsshim to v0.8.23#6231estesp merged 1 commit intocontainerd:release/1.5from
Conversation
|
Hi @dcantah. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7de3127 to
0892ddd
Compare
|
This PR bumps ttrpc to 1.1.0 also so this is kinda redundant #6229. Think it's better to update them individually so I'll wait for that to get in and rebase after. |
|
Build succeeded.
|
|
#6229 was merged; could you rebase this PR so that the diff reflects that the ttrpc changes are not actually in this PR?
note to self / reviewers: corresponding fix for the main branch (and v1.6.x) looks to be #6230 |
|
@thaJeztah Yep! Noted above that I'd need to rebase afterwards but likely should've kept this as a draft until #6229 got in. Doing now Edit: This should be ready to go now (assuming the CI is happy and green) |
This tag contains some changes for the Windows shim for retrying stdio named pipe connections if containerd restarts/crashes. It also is built with v1.1.0 of ttrpc which has some fixes for a deadlock we'd observed on Windows. Signed-off-by: Daniel Canter <[email protected]>
0892ddd to
2bd3f18
Compare
|
Build succeeded.
|
This tag contains some changes for the Windows shim for retrying stdio named pipe connections if containerd restarts/crashes. As the Windows runhcs shim is cloned and built based off of the tag present in hcsshim's go.mod, it will also contain a ttrpc
deadlock fix present in ttrpc v1.1.0 as that's the version hcsshim has vendored.