Skip to content

Implement CDI support#6195

Closed
bart0sh wants to merge 2 commits intocontainerd:mainfrom
bart0sh:PR001-support-CDI
Closed

Implement CDI support#6195
bart0sh wants to merge 2 commits intocontainerd:mainfrom
bart0sh:PR001-support-CDI

Conversation

@bart0sh
Copy link
Copy Markdown
Contributor

@bart0sh bart0sh commented Nov 2, 2021 •
edited
Loading

This is an initial implementation of the CDI support made on two levels:

  • client side (ctr)
  • server side (CRI)

NOTE: this is an alternative approach to NRI: https://github.com/klihub/nri/blob/5f41c0fbfab8c026f94db5e3f3dc91ce9ff509bf/v2alpha1/plugins/cdi-resolver/cdi-resolver.go#L48-L60
CRI implementation used this code

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Nov 2, 2021

Hi @bart0sh. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 2, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 2, 2021

Build succeeded.

@AkihiroSuda AkihiroSuda mentioned this pull request Nov 5, 2021
Closed
@mxpv
Copy link
Copy Markdown
Member

mxpv commented Apr 19, 2022

There is another similar CDI PR #6654 was merged in a couple weeks ago, so I'm going to close this one. Please feel free to open PRs if there are still gaps left.

@mxpv mxpv closed this Apr 19, 2022
@bart0sh bart0sh mentioned this pull request May 17, 2023
Closed
@elezar elezar mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bart0sh @k8s-ci-robot @mxpv @dmcgowan