[release/1.5] Update test timeout based on recent cancellations#6134
[release/1.5] Update test timeout based on recent cancellations#6134fuweid merged 1 commit intocontainerd:release/1.5from
Conversation
Signed-off-by: Phil Estes <[email protected]> (cherry picked from commit 4ed3c52) Signed-off-by: Daniel Canter <[email protected]>
|
Hi @dcantah. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM; the 40 is fine and should be sufficient for Go 1.16.x; until we move to Go 1.17 we won't pay the extra "tax" on compile time/go.mod resolution which seemed to bump Linux integration runs by 2-4 minutes.
4 participants
This change bumps the Linux integration tests timeouts in the CI for release/1.5 to 40 minutes to handle some recent cancellations.
@estesp I'd seen you'd increased the Windows and Linux runs to 35 first because of some regressions that seem to be related to go 1.17 (we're still on 1.16.8 on release/1.5) and then separately changed Linux to 40 afterwards. Let me know if just jumping to the 40 change makes sense here or we should just bring in the 35 change for both the Windows and Linux runs instead (or both if we think we're going to bump to 1.17 in the near term on release/1.5 as the Windows tests could use the change to 35 then).
Edited by @fuweid
cherry-pick from #6107