[release/1.5] task delete: Closes task IO before waiting#6129
[release/1.5] task delete: Closes task IO before waiting#6129kevpar merged 1 commit intocontainerd:release/1.5from
Conversation
After containerd restarts, it will try to recover its sandboxes, containers, and images. If it detects a task in the Created or Stopped state, it will be removed. This will cause the containerd process it hang on Windows on the t.io.Wait() call. Calling t.io.Close() beforehand will solve this issue. Additionally, the same issue occurs when trying to stopp a sandbox after containerd restarts. This will solve that case as well. Signed-off-by: Claudiu Belu <[email protected]> (cherry picked from commit 55faa5e) Signed-off-by: Daniel Canter <[email protected]>
|
Hi @dcantah. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
@claudiubelu Thanks for this btw! Got bit by this when adding stdio pipe reconnect logic here microsoft/hcsshim#1197. Gist was if nothing ever came down one of the streams (process never logged to stderr for example) we'd never accept a new connection so the waitgroup.Done would never fire for stderr and we'd just sit there stuck. |
|
/ok-to-test |
|
@dcantah: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Worth a shot 🤷♂️ Thought reviewers would be able to kick off a k8s run, is it only maintainers? Edit: Ahh, it's people in the org now that I clicked on the containerd hyperlink in the original post from the bot. |
|
/ok-to-test |
|
@claudiubelu: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
6 participants
After containerd restarts, it will try to recover its sandboxes,
containers, and images. If it detects a task in the Created or
Stopped state, it will be removed. This will cause the containerd
process it hang on Windows on the t.io.Wait() call.
Calling t.io.Close() beforehand will solve this issue.
Additionally, the same issue occurs when trying to stopp a sandbox
after containerd restarts. This will solve that case as well.
Signed-off-by: Claudiu Belu [email protected]
(cherry picked from commit 55faa5e)
Signed-off-by: Daniel Canter [email protected]