Skip to content

[release/1.5] Use github images for integration tests#6041

Merged
AkihiroSuda merged 1 commit intocontainerd:release/1.5from
dmcgowan:backport-1.5-use-ghcr-test-images
Sep 23, 2021
Merged

[release/1.5] Use github images for integration tests#6041
AkihiroSuda merged 1 commit intocontainerd:release/1.5from
dmcgowan:backport-1.5-use-ghcr-test-images

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan commented Sep 22, 2021

Backport #6032

@dmcgowan
Use github images for integration tests
1477059 
Signed-off-by: Derek McGowan <[email protected]>
(cherry picked from commit 3e72e33)
Signed-off-by: Derek McGowan <[email protected]>
@kzys
Copy link
Copy Markdown
Member

kzys commented Sep 22, 2021

The error looks new. It shouldn't be related to the change though.

FAIL
Makefile:196: recipe for target 'cri-integration' failed
./script/test/utils.sh: line 95: 20908 Terminated              keepalive "sudo PATH=${PATH} bin/containerd ${CONTAINERD_FLAGS}" ${RESTART_WAIT_PERIOD} &> ${report_dir}/containerd.log
make: *** [cri-integration] Error 1

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 22, 2021

Build succeeded.

Zyqsempai
Zyqsempai approved these changes Sep 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit 4de759a into containerd:release/1.5 Sep 23, 2021
@dmcgowan dmcgowan deleted the backport-1.5-use-ghcr-test-images branch March 23, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

+1 more reviewer

@Zyqsempai Zyqsempai Zyqsempai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmcgowan @kzys @Zyqsempai @AkihiroSuda