Add PullStats method #60
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
api/grpc/server/server.go
Outdated
Member
There was a problem hiding this comment.
Why can't this just return error?
Contributor
Author
There was a problem hiding this comment.
Like on the first failure? I thought it might be client task to handle errors. Skip stats with error or error out.
Member
|
I think we can remove the streaming method, no point of supporting both. |
Contributor
Author
|
I removed streaming method. |
supervisor/stats.go
Outdated
Member
There was a problem hiding this comment.
Should these conversions happen in the API package cuz this brings in the types import into the supervisor package?
It returns stats one time for bulk of containers Old method for streaming is removed. Signed-off-by: Alexander Morozov <[email protected]>
Contributor
Author
|
@crosbymichael I moved conversion to api/server package |
Member
|
This was done in the shim branch |
crosbymichael
added a commit
to crosbymichael/containerd
that referenced
this pull request
Dec 10, 2018
``` 1152b96 (HEAD -> master, origin/master) Merge pull request containerd#73 from gliptak/gofmt1 afd5981 Gofmt cgroup_test 65ce98b Merge pull request containerd#69 from cclerget/master-weight-pointer 0f372c6 Merge pull request containerd#71 from JoeWrightss/patch-1 f48bd85 Fixs return error message 10cd53e Merge pull request containerd#70 from gliptak/patch-1 64bade4 Take value instead of pointer value b49c471 Correct ineffassign warning 3bc6dde Merge pull request containerd#68 from cclerget/master-net_prio-typo 6b552a8 Fix net_prio typo c0437c3 Merge pull request containerd#67 from gpanouts/get-all-cgroup-tasks a31a0ff Add functionality for retrieving all tasks of a cgroup 82cb49f Merge pull request containerd#63 from ChrsMark/lenient-subsystems-checking 7d825b2 Add test for cgroups load when missing hierarchy in one subsystem f6cbfb4 Change Load function in order to be more lenient on subsystems' checking 965bb1d Merge pull request containerd#66 from crosbymichael/systemdci ab9ec0e (fork/systemdci, systemdci) Add go-systemd dep for CI testing 0e94a83 Merge pull request containerd#59 from gliptak/patch-1 4479d11 Merge pull request containerd#62 from estesp/fix-gofmt 9beb998 Merge pull request containerd#61 from gliptak/patch-3 9a09e58 Fix gofmt of systemd.go 84e6e6e Merge pull request containerd#60 from gliptak/patch-2 e13f6cc Add GoReportCard badge to README d124595 Add Go 1.11 to Travis d961ab9 Correct typo d240072 Merge pull request containerd#57 from estesp/project-update e4cf832 Add project references and use common project travis 8baeff6 Merge pull request containerd#56 from grantseltzer/patch-1 9de57ff Add godoc badge to README.md 5017d4e Merge pull request containerd#54 from WeiZhang555/bugfix 13aaafd Bugfix: can't write to cpuset cgroup 58556f5 Merge pull request containerd#53 from baude/systemdslicedelegate 15ed73c systemd-239+ no longer allows delegate slice 3024bc7 Merge pull request containerd#52 from Sykomaniac/bugfix/slice-name 2596f33 Remove call to unitName 2e2922e Merge pull request containerd#51 from containerd/type 0f3de2f (type) Fix empty device type ``` Signed-off-by: Michael Crosby <[email protected]>
robertgzr
pushed a commit
to balena-os/balena-containerd
that referenced
this pull request
Mar 4, 2019
``` 1152b96 (HEAD -> master, origin/master) Merge pull request containerd#73 from gliptak/gofmt1 afd5981 Gofmt cgroup_test 65ce98b Merge pull request containerd#69 from cclerget/master-weight-pointer 0f372c6 Merge pull request containerd#71 from JoeWrightss/patch-1 f48bd85 Fixs return error message 10cd53e Merge pull request containerd#70 from gliptak/patch-1 64bade4 Take value instead of pointer value b49c471 Correct ineffassign warning 3bc6dde Merge pull request containerd#68 from cclerget/master-net_prio-typo 6b552a8 Fix net_prio typo c0437c3 Merge pull request containerd#67 from gpanouts/get-all-cgroup-tasks a31a0ff Add functionality for retrieving all tasks of a cgroup 82cb49f Merge pull request containerd#63 from ChrsMark/lenient-subsystems-checking 7d825b2 Add test for cgroups load when missing hierarchy in one subsystem f6cbfb4 Change Load function in order to be more lenient on subsystems' checking 965bb1d Merge pull request containerd#66 from crosbymichael/systemdci ab9ec0e (fork/systemdci, systemdci) Add go-systemd dep for CI testing 0e94a83 Merge pull request containerd#59 from gliptak/patch-1 4479d11 Merge pull request containerd#62 from estesp/fix-gofmt 9beb998 Merge pull request containerd#61 from gliptak/patch-3 9a09e58 Fix gofmt of systemd.go 84e6e6e Merge pull request containerd#60 from gliptak/patch-2 e13f6cc Add GoReportCard badge to README d124595 Add Go 1.11 to Travis d961ab9 Correct typo d240072 Merge pull request containerd#57 from estesp/project-update e4cf832 Add project references and use common project travis 8baeff6 Merge pull request containerd#56 from grantseltzer/patch-1 9de57ff Add godoc badge to README.md 5017d4e Merge pull request containerd#54 from WeiZhang555/bugfix 13aaafd Bugfix: can't write to cpuset cgroup 58556f5 Merge pull request containerd#53 from baude/systemdslicedelegate 15ed73c systemd-239+ no longer allows delegate slice 3024bc7 Merge pull request containerd#52 from Sykomaniac/bugfix/slice-name 2596f33 Remove call to unitName 2e2922e Merge pull request containerd#51 from containerd/type 0f3de2f (type) Fix empty device type ``` Signed-off-by: Michael Crosby <[email protected]>
jepio
pushed a commit
to jepio/containerd
that referenced
this pull request
Dec 3, 2021
Add Go 1.11 to Travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It returns stats one time for bulk of containers
ping @tonistiigi