Skip to content

[release/1.5] cherry-pick: cri: add devices for privileged container#5981

Merged
fuweid merged 1 commit intocontainerd:release/1.5from
scuzhanglei:release-1.5-privileged-device
Sep 20, 2021
Merged

[release/1.5] cherry-pick: cri: add devices for privileged container#5981
fuweid merged 1 commit intocontainerd:release/1.5from
scuzhanglei:release-1.5-privileged-device

Conversation

@scuzhanglei
Copy link
Copy Markdown
Contributor

Cherry-pick PR #5939 from main to release/1.5

@k8s-ci-robot
Copy link
Copy Markdown

Hi @scuzhanglei. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 13, 2021

Build succeeded.

@scuzhanglei scuzhanglei force-pushed the release-1.5-privileged-device branch from cf3026f to 3c93e7b Compare September 13, 2021 03:47
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 13, 2021

Build succeeded.

@scuzhanglei
Copy link
Copy Markdown
Contributor Author

/test all

@k8s-ci-robot
Copy link
Copy Markdown

@scuzhanglei: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scuzhanglei
Copy link
Copy Markdown
Contributor Author

/retest

@k8s-ci-robot
Copy link
Copy Markdown

@scuzhanglei: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scuzhanglei scuzhanglei force-pushed the release-1.5-privileged-device branch from 3c93e7b to 5926114 Compare September 15, 2021 09:19
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 15, 2021

Build succeeded.

@estesp
Copy link
Copy Markdown
Member

estesp commented Sep 15, 2021

You need to rebase on the head of release/1.5 to pick up the change in test image reference required for tests to pass. Thanks!

@scuzhanglei scuzhanglei force-pushed the release-1.5-privileged-device branch from 5926114 to 12dd1ec Compare September 16, 2021 01:38
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 16, 2021

Build succeeded.

@scuzhanglei
Copy link
Copy Markdown
Contributor Author

still failed.

Signed-off-by: zhanglei <[email protected]>
(cherry picked from commit 756f4a3)
@scuzhanglei scuzhanglei force-pushed the release-1.5-privileged-device branch from 12dd1ec to 514137a Compare September 18, 2021 10:02
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 18, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 3f4f6bc into containerd:release/1.5 Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants