Skip to content

[release/1.4] Backport go.mod: Update hcsshim to v0.8.21#5957

Merged
AkihiroSuda merged 1 commit intocontainerd:release/1.4from
dcantah:hcsshim-backport-1.4
Sep 8, 2021
Merged

[release/1.4] Backport go.mod: Update hcsshim to v0.8.21#5957
AkihiroSuda merged 1 commit intocontainerd:release/1.4from
dcantah:hcsshim-backport-1.4

Conversation

@dcantah
Copy link
Copy Markdown
Member

@dcantah dcantah commented Sep 7, 2021

This version brings in some bug fixes to layer handling. The actual fix isn't
present in the diff as it's not used here, but the Windows shim is built from
the tag present in go.mod, so the fix will be in the Windows shim on a new release
of Containerd if this tag is in.

Signed-off-by: Daniel Canter [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @dcantah. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 7, 2021

Build succeeded.

@dcantah
Copy link
Copy Markdown
Member Author

dcantah commented Sep 7, 2021

vndr gets rid of non-go files it seems, but that begs the question of how the .syso manifest didn't get removed before with any other vendors..

This version brings in some bug fixes to layer handling. The actual fix isn't
present in the diff as it's not used here, but the Windows shim is built from
the tag present in go.mod, so the fix will be in the Windows shim on a new release
of Containerd if this tag is in.

Signed-off-by: Daniel Canter <[email protected]>
@dcantah dcantah force-pushed the hcsshim-backport-1.4 branch from d8a8050 to a503d4c Compare September 7, 2021 21:09
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Sep 7, 2021

Build succeeded.

@dcantah dcantah changed the title [release/1.4] go.mod: Update hcsshim to v0.8.21 [release/1.4] Backport go.mod: Update hcsshim to v0.8.21 Sep 7, 2021
@dcantah
Copy link
Copy Markdown
Member Author

dcantah commented Sep 7, 2021

@estesp As you've looked at the other two 😉

@AkihiroSuda AkihiroSuda added the easy-to-review Easy to review label Sep 8, 2021
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit e25371f into containerd:release/1.4 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants