Use cgroups.AddProc() for cgroups v1#5738
Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom Mar 25, 2022
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
|
Build succeeded.
|
|
Build succeeded.
|
Member
Author
|
Failure looks consistent across multiple jobs; Don't think that's related to my changes in containerd/cgroups, but this PR brings in some other changes, so perhaps that's related. |
Member
Author
|
opened #5740 to test just the cgroups update |
thaJeztah
force-pushed
the
simplify_cgroup_add
branch
from
fd3c11d to
b44b9b3
Compare
Member
Author
|
Ah.. I'm stupid; I didn't copy the replace rule to the client/integration package, and that of course doesn't inherit the replace. |
|
Build succeeded.
|
thaJeztah
force-pushed
the
simplify_cgroup_add
branch
2 times, most recently
from
c8a5bbd to
fd7470e
Compare
|
Build succeeded.
|
thaJeztah
force-pushed
the
simplify_cgroup_add
branch
from
fd7470e to
d21b5bc
Compare
thaJeztah
changed the title
All occurrences only passed a PID, so we can use this utility to make the code more symmetrical with their cgroups v2 counterparts. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
simplify_cgroup_add
branch
from
d21b5bc to
c091d48
Compare
|
Build succeeded.
|
Member
|
Is this still supposed to be in draft or ready to review now @thaJeztah ? |
Member
Author
|
Ready now! Was waiting for CI to finish after I rebased 😅 |
Member
Author
|
@AkihiroSuda this LGTY? |
AkihiroSuda
approved these changes
Mar 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on
containerd/cgroups#200containerd/cgroups#202All occurrences only passed a PID, so we can use this utility to make the code more symmetrical with their cgroups v2 counterparts.