Skip to content

Update Go to 1.16.6#5722

Merged
dmcgowan merged 2 commits intocontainerd:mainfrom
AkihiroSuda:go1.16.6
Jul 13, 2021
Merged

Update Go to 1.16.6#5722
dmcgowan merged 2 commits intocontainerd:mainfrom
AkihiroSuda:go1.16.6

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Jul 13, 2021

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 13, 2021

Build succeeded.

@AkihiroSuda AkihiroSuda mentioned this pull request Jul 13, 2021
Merged
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jul 13, 2021

Build succeeded.

@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Jul 13, 2021

CI failure (cgroup2) is unrelated

default:         rpc error: code = Unknown desc = failed to pull and unpack image "docker.io/library/httpd:latest": failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/httpd/manifests/sha256:51dabee6ad1cca2ae3a80e974224f30e7121dab1da9edf62e11179f8c652b09e: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
    default:     occurred

thaJeztah
thaJeztah approved these changes Jul 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we really need a check for the integration/client go.mod / tidy 😞

Zyqsempai
Zyqsempai approved these changes Jul 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

estesp
estesp approved these changes Jul 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp mentioned this pull request Jul 13, 2021
Closed
kzys
kzys approved these changes Jul 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and it is green now :)

@dmcgowan dmcgowan merged commit d527926 into containerd:main Jul 13, 2021
@thaJeztah thaJeztah mentioned this pull request Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

+1 more reviewer

@Zyqsempai Zyqsempai Zyqsempai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AkihiroSuda @kzys @dmcgowan @estesp @thaJeztah @Zyqsempai