[release/1.5 backport] Update hcsshim to 0.8.18#5715
[release/1.5 backport] Update hcsshim to 0.8.18#5715dmcgowan merged 1 commit intocontainerd:release/1.5from
Conversation
|
Hi @dcantah. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
dcantah
force-pushed
the
backport-hcsshim-0.8.18
branch
from
a635da2 to
711edc2
Compare
|
Build succeeded.
|
dcantah
force-pushed
the
backport-hcsshim-0.8.18
branch
from
711edc2 to
f80851c
Compare
|
Build succeeded.
|
|
What's goin on here.. |
|
do you have the same version of Golang that's being used in |
0.8.18 contains a fix for shim delete behavior, please see: microsoft/hcsshim#1041 This time it brings in quite a few new files as 1.5 was on 0.8.16 of hcsshim and 0.8.17 brought in a few new things. 0.8.18 doesn't actually bring in any new vendored files but the version of the runhcs-shim built is based off of the commit that's vendored into Containerd, so we need to vendor the version that has the fix. Signed-off-by: Daniel Canter <[email protected]> (cherry picked from commit a81f05f) Signed-off-by: Daniel Canter <[email protected]>
dcantah
force-pushed
the
backport-hcsshim-0.8.18
branch
from
f80851c to
a695a07
Compare
|
Build succeeded.
|
|
@estesp Nope I was on 1.15 😮 That seemed to have done it, thanks! Weird though, I was on 1.15 when I made the initial PR also. |
|
fyi @jsturtevant |
|
Build succeeded.
|
5 participants
Cherry-pick of #5673
Fixes #5094
0.8.18 contains a fix for shim delete behavior, please see:
microsoft/hcsshim#1041
This time it brings in quite a few new files as 1.5 was on 0.8.16 of hcsshim
and 0.8.17 brought in a few new things. 0.8.18 doesn't actually bring in any new
vendored files but the version of the runhcs-shim built is based off of the commit
that's vendored into Containerd, so we need to vendor the version that has the fix.
Signed-off-by: Daniel Canter [email protected]
(cherry picked from commit a81f05f)
Signed-off-by: Daniel Canter [email protected]