remotes/docker: log registry URLs as info instead of debug#5681
Merged
fuweid merged 1 commit intocontainerd:mainfrom Apr 20, 2022
Merged
remotes/docker: log registry URLs as info instead of debug#5681fuweid merged 1 commit intocontainerd:mainfrom
fuweid merged 1 commit intocontainerd:mainfrom
Conversation
|
Build succeeded.
|
fuweid
reviewed
Jul 3, 2021
| continue | ||
| } | ||
| log.G(ctx).Debug("trying alternative url") | ||
| log.G(ctx).Info("request") |
Member
There was a problem hiding this comment.
I'm not sure. It may result in leaking some secret stuff.
Member
There was a problem hiding this comment.
It should at least be clear the request is from dest.URLs
Member
There was a problem hiding this comment.
I think it should contain the URL....there is not too much information in ctx...
Member
Author
There was a problem hiding this comment.
Because of log.WithLogger(ctx, log.G(ctx).WithField("url", us)), log.G returns a logger with url=us. Let me double-check.
Registry URLs are important and should be logged even the logging level is info. Fixes containerd#5486. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
changed the title
|
Build succeeded.
|
dmcgowan
approved these changes
Mar 15, 2022
|
Build succeeded.
|
Member
Author
|
@AkihiroSuda @fuweid Can you take a look? |
fuweid
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registry URLs are important and should be logged even the logging level is info.
Fixes #5486.