Add ctr command label in NewContainerOpts#5660
Conversation
|
Hi @BigVan. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Maybe we should have another flag like —snapshot-label? |
BigVan
force-pushed
the
main
branch
2 times, most recently
from
ee4c5fb to
1acd93b
Compare
sounds good. |
|
Build succeeded.
|
|
/ok-to-test |
|
Build succeeded.
|
|
Changes are LGTM. @AkihiroSuda could we run Github Actions for this PR? |
|
@BigVan Please use real name to sign off in the commit message. |
|
Build succeeded.
|
add '--snapshotter-labels' in ctr run and ctr c create which can pass labels to snappshotter on preparing new snapshot. Pass command label to snapshotter can help it determine which kind of writable snapshots should be provide. For some snapshotter, such as overlaybd: ( https://github.com/alibaba/accelerated-container-image ), it can provide 2 kind of writable snapshot (overlayfs dir or blockdevice) by command label values. Signed-off-by: Yifan Yuan <[email protected]>
|
Build succeeded.
|
7 participants
Pass command label to snapshotter can help it determine which kind of writable snapshots should be provide.
For some snapshotter, such as overlaybd ( https://github.com/alibaba/accelerated-container-image ), it can provide 2 kind of writable snapshot(overlayfs dir or blockdevice) by command label values.