move sys.FMountat() into mount package and un-export#5641
Merged
fuweid merged 2 commits intocontainerd:mainfrom Jun 24, 2021
Merged
move sys.FMountat() into mount package and un-export#5641fuweid merged 2 commits intocontainerd:mainfrom
fuweid merged 2 commits intocontainerd:mainfrom
Conversation
|
Build succeeded.
|
|
Build succeeded.
|
It's the only location this is used, so might as well move it into that package. I could not find external users of this utility, so not adding an alias / deprecation. Signed-off-by: Sebastiaan van Stijn <[email protected]>
It's only used internally, so we can un-export this utility until it is needed elsewhere. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
move_sys_fmountat
branch
from
115535f to
a964cf0
Compare
|
Build succeeded.
|
|
Build succeeded.
|
kzys
approved these changes
Jun 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's the only location this is used, so might as well move it into that package. I could not find external users of this utility, so not adding an alias / deprecation.
Given that this function is only used internally, we can un-export this utility until it is needed elsewhere.
relates to #2502, which added this