Skip to content

[release/1.5 backport] content/local: inline sys.StatATimeAsTime()#5634

Merged
crosbymichael merged 1 commit intocontainerd:release/1.5from
thaJeztah:1.5_backport_inline_statatimeastime
Jun 22, 2021
Merged

[release/1.5 backport] content/local: inline sys.StatATimeAsTime()#5634
crosbymichael merged 1 commit intocontainerd:release/1.5from
thaJeztah:1.5_backport_inline_statatimeastime

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

cherry-pick of #5633
relates to docker/cli#3154

The sys.StatATimeAsTime() utility is currently only used in a single place,
but because it's living in the "sys" package, also brings in other dependencies,
such as Microsoft/hcsshim.

This patch inlines the code from sys.StatATimeAsTime(), to remove that dependency.

The sys.StatATimeAsTime() utility is currently only used in a single place,
but because it's living in the "sys" package, also brings in other dependencies,
such as Microsoft/hcsshim.

This patch inlines the code from sys.StatATimeAsTime(), to remove that dependency.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 63c185d)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 22, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah marked this pull request as ready for review June 22, 2021 16:34
@thaJeztah
Copy link
Copy Markdown
Member Author

moved out of draft, because #5633 was merged

@crosbymichael
Copy link
Copy Markdown
Member

LGTM

@crosbymichael crosbymichael merged commit 8098a6e into containerd:release/1.5 Jun 22, 2021
@thaJeztah thaJeztah deleted the 1.5_backport_inline_statatimeastime branch June 22, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants