Skip to content

archive: Expose ChangeWriter to allow customized diff computing#5615

Merged
estesp merged 1 commit intocontainerd:mainfrom
ktock:exposechangewriter
Jun 21, 2021
Merged

archive: Expose ChangeWriter to allow customized diff computing#5615
estesp merged 1 commit intocontainerd:mainfrom
ktock:exposechangewriter

Conversation

@ktock
Copy link
Copy Markdown
Member

@ktock ktock commented Jun 17, 2021

changeWriter in archive package provides a generic functionality to create tar archives from the filesystem change information. Especially *archive.changeWriter.HandleChange is useful for creating filesystem diff archive combining with continuity's diff computing functionality (fs.Changes()).

This PR allows containerd users to customize diffing logic relying on changeWriter for creating tar archives. An example use case of this is for the overlayfs-oriented diff logic discussed in BuildKit (moby/buildkit#2181 and containerd/continuity#145).

@ktock ktock marked this pull request as draft June 17, 2021 06:53
@ktock ktock force-pushed the exposechangewriter branch 3 times, most recently from d21d402 to 1da809f Compare June 17, 2021 07:21
@ktock ktock marked this pull request as ready for review June 17, 2021 07:21
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 17, 2021

Build succeeded.

@ktock
Copy link
Copy Markdown
Member Author

ktock commented Jun 17, 2021

Linter timeouts ( level=error msg="Timeout exceeded: try increasing it by passing --timeout option").
Could we rerun tests?

Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktock
Copy link
Copy Markdown
Member Author

ktock commented Jun 18, 2021

CI failure doesn't seem to related to this patch. (maybe we need to re-run tests)

	gopkg.in/[email protected]: unrecognized import path "gopkg.in/yaml.v3": reading https://gopkg.in/yaml.v3?go-get=1: 502 Bad Gateway

@ktock ktock force-pushed the exposechangewriter branch from 1da809f to 4a46ea2 Compare June 21, 2021 09:48
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 21, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit c07711c into containerd:main Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants