Skip to content

ctr flags of container rootfs propagation#5611

Merged
fuweid merged 1 commit intocontainerd:masterfrom
cloudtogo:rootfs-propagation
Jun 17, 2021
Merged

ctr flags of container rootfs propagation#5611
fuweid merged 1 commit intocontainerd:masterfrom
cloudtogo:rootfs-propagation

Conversation

@kitt1987
Copy link
Copy Markdown
Contributor

@kitt1987 kitt1987 commented Jun 16, 2021 •
edited
Loading

Implement #5381.

A new flag --rootfs-propagation is added to ctr run and ctr container create to set propagation of the container rootfs.
Its value can be one of the propagation settings lists in Configuare bind propagation.

If the flag is set, say "rshared", users can check settings through ctr c info CONTAINER, and get the output below.

{
    "Spec": {
        "linux": {
            "rootfsPropagation": "rshared"
        }
    }
}

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jun 16, 2021

Hi @kitt1987. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 16, 2021

Build succeeded.

@kitt1987 kitt1987 force-pushed the rootfs-propagation branch from dc2fa26 to 621d697 Compare June 16, 2021 08:41
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 16, 2021

Build succeeded.

@kitt1987 kitt1987 force-pushed the rootfs-propagation branch from 621d697 to eb2f580 Compare June 16, 2021 11:08
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 16, 2021

Build succeeded.

kzys
kzys approved these changes Jun 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@containerd/committers Can someone approve GitHub Actions?

AkihiroSuda
AkihiroSuda requested changes Jun 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign with your full name

@kitt1987 kitt1987 force-pushed the rootfs-propagation branch from eb2f580 to 05e5153 Compare June 17, 2021 02:04
@kitt1987
Copy link
Copy Markdown
Contributor Author

kitt1987 commented Jun 17, 2021

Please sign with your full name

@AkihiroSuda Updated. Thanks.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 17, 2021

Build succeeded.

fuweid
fuweid approved these changes Jun 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 11304a4 into containerd:master Jun 17, 2021
@kitt1987 kitt1987 mentioned this pull request Jun 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kitt1987 @k8s-ci-robot @kzys @AkihiroSuda @fuweid