Allow to pass --no-cgroups option to nvidia-container-cli#5604
Merged
estesp merged 1 commit intocontainerd:masterfrom Jun 14, 2021
Merged
Allow to pass --no-cgroups option to nvidia-container-cli#5604estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Kohei Tokunaga <[email protected]>
ktock
changed the title
AkihiroSuda
approved these changes
Jun 14, 2021
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5603
Through discussion in moby/moby#38729 (comment) and containerd/nerdctl#251 (review), it turns out we need to pass
--no-cgroupsoption tonvidia-container-clifor using it in rootless environmetns.This commit allows
nvidiapkg to do this.