Update release 1.5 dependencies to latest master as of jun 9#5587
Update release 1.5 dependencies to latest master as of jun 9#5587dims wants to merge 5 commits intocontainerd:release/1.5from
Conversation
Signed-off-by: Priyanka Saggu <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
|
Build succeeded.
|
Signed-off-by: Davanum Srinivas <[email protected]>
dims
force-pushed
the
update-release-1.5-dependencies-to-latest-master-jun-9
branch
from
91613a4 to
24d79bf
Compare
dims
changed the title
|
Build succeeded.
|
|
|
||
| require ( | ||
| github.com/Microsoft/go-winio v0.4.17 | ||
| github.com/Microsoft/go-winio v0.5.0 |
There was a problem hiding this comment.
IIRC, there were some breaking changes in v0.5.0, so we may have to be careful with this one
| github.com/cespare/xxhash/v2 v2.1.1 h1:6MnRN8NT7+YBpUIWxHtefFZOKTAPgGjpQSxqLNn0+qY= | ||
| github.com/cespare/xxhash/v2 v2.1.1/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs= | ||
| github.com/checkpoint-restore/go-criu/v4 v4.1.0/go.mod h1:xUQBLp4RLc5zJtWY++yjOoMoB5lihDt7fai+75m+rGw= | ||
| github.com/checkpoint-restore/go-criu/v5 v5.0.0/go.mod h1:cfwC0EG7HMUenopBsUf9d89JlCLQIfgVcNsNN0t6T2M= |
There was a problem hiding this comment.
This will also be updating to a new major version, so we should be careful picking this, unless we have a specific reason to update the dependency (I think this is coming in because this PR updates runc v1.0.0-rc95, but we only use a single package (libcontainer/user from runc), so we should no longer have a need to update it, unless there were changes in that package
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
I'm a bit cautious with some of the updates; we should be careful updating these in a patch release if there's no specific reason to require these changes. Especially with go modules, updating the version here will also force any consumer of containerd go module to update their dependencies to these newer versions, so there's a risk that containerd itself is not affected by the updated version (it may not be using the code), but consumers of containerd may be, and will now be forced to accept (possibly breaking) changes.
5 participants
pick up changes from to 1.5 release branch: