Skip to content

Enable cri-integration in Windows Periodic Tests#5580

Merged
estesp merged 1 commit intocontainerd:masterfrom
adelina-t:enable_cri_integration
Jun 9, 2021
Merged

Enable cri-integration in Windows Periodic Tests#5580
estesp merged 1 commit intocontainerd:masterfrom
adelina-t:enable_cri_integration

Conversation

@adelina-t
Copy link
Copy Markdown

@adelina-t adelina-t commented Jun 8, 2021

Signed-off-by: Adelina Tuvenie [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jun 8, 2021

Hi @adelina-t. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 8, 2021

Build succeeded.

@estesp
Copy link
Copy Markdown
Member

estesp commented Jun 8, 2021

Looks like a whitespace issue in the commit; see git show --check c15424591a4d352f47178488b68f9c1b907bd4c3

@adelina-t adelina-t force-pushed the enable_cri_integration branch from db0cbb4 to 0a87540 Compare June 8, 2021 14:52
@adelina-t adelina-t force-pushed the enable_cri_integration branch from 0a87540 to af5a130 Compare June 8, 2021 14:53
@adelina-t adelina-t changed the title Enable cri-integration in Windows Periodic Tests [Wait for test] Enable cri-integration in Windows Periodic Tests Jun 8, 2021
@adelina-t
Copy link
Copy Markdown
Author

adelina-t commented Jun 8, 2021 •
edited
Loading

Tagging it with WAIT. One run failed, need to check if it was anything related to the PR. Will remove tag as I know the context. The failure was unrelated, Azure failed to spawn resource. Removing WAIT

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 8, 2021

Build succeeded.

@adelina-t adelina-t changed the title [Wait for test] Enable cri-integration in Windows Periodic Tests Enable cri-integration in Windows Periodic Tests Jun 8, 2021
estesp
estesp approved these changes Jun 8, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Zyqsempai
Zyqsempai approved these changes Jun 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit a545df3 into containerd:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

+1 more reviewer

@Zyqsempai Zyqsempai Zyqsempai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adelina-t @k8s-ci-robot @estesp @Zyqsempai