Skip to content

test integration: Adds a test that restarts a failed container#5578

Merged
mxpv merged 1 commit intocontainerd:mainfrom
claudiubelu:integration/failed-container
Jul 9, 2021
Merged

test integration: Adds a test that restarts a failed container#5578
mxpv merged 1 commit intocontainerd:mainfrom
claudiubelu:integration/failed-container

Conversation

@claudiubelu
Copy link
Copy Markdown
Contributor

@claudiubelu claudiubelu commented Jun 8, 2021 •
edited
Loading

If a container failed to start due to a bad command, the container could not be recreated with a proper command in its stead. Adds a test that verifies this scenario.

Related: #5188

Signed-off-by: Claudiu Belu [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jun 8, 2021

Hi @claudiubelu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@claudiubelu claudiubelu force-pushed the integration/failed-container branch from d5f0fe3 to 54e84ce Compare June 8, 2021 13:56
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 8, 2021

Build succeeded.

@claudiubelu claudiubelu force-pushed the integration/failed-container branch from 54e84ce to da639b1 Compare June 22, 2021 12:20
@claudiubelu claudiubelu changed the title WIP: test integration: Adds a test that restarts a failed container test integration: Adds a test that restarts a failed container Jun 22, 2021
@claudiubelu claudiubelu mentioned this pull request Jun 22, 2021
Closed
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 22, 2021

Build succeeded.

@claudiubelu
test integration: Adds a test that restarts a failed container
04ab441 
If a container failed to start due to a bad command, the container could not be
recreated with a proper command in its stead. Adds a test that verifies this scenario.

Signed-off-by: Claudiu Belu <[email protected]>
@claudiubelu claudiubelu force-pushed the integration/failed-container branch from da639b1 to 04ab441 Compare June 25, 2021 10:33
@kzys
Copy link
Copy Markdown
Member

kzys commented Jul 2, 2021

/ok-to-test

@mxpv
Copy link
Copy Markdown
Member

mxpv commented Jul 3, 2021

/retest

mxpv
mxpv approved these changes Jul 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@claudiubelu
Copy link
Copy Markdown
Contributor Author

claudiubelu commented Jul 7, 2021

/test pull-containerd-node-e2e

@kzys
Copy link
Copy Markdown
Member

kzys commented Jul 9, 2021

/retest

@kzys
Copy link
Copy Markdown
Member

kzys commented Jul 9, 2021

@containerd/committers Can someone take a look and merge?

@mxpv mxpv merged commit d38c186 into containerd:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@mxpv mxpv mxpv approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@claudiubelu @k8s-ci-robot @kzys @mxpv