Skip to content

Makefile: FHS conformant manpage installation pathes#5577

Merged
estesp merged 1 commit intocontainerd:masterfrom
oss-qm:submit/fhs-manpage
Jun 11, 2021
Merged

Makefile: FHS conformant manpage installation pathes#5577
estesp merged 1 commit intocontainerd:masterfrom
oss-qm:submit/fhs-manpage

Conversation

@metux
Copy link
Copy Markdown
Contributor

@metux metux commented Jun 8, 2021

FHS mandates manpages should go to /usr/share/man (or /usr/local/share/man,
for site local installations) -- /usr/man was an fallout of some ancient
Unices that haven't been fully FHS conformant and usually just a symlink to
/usr/share/man, if existing at all.

Distros sometimes need to override this (eg. MVCC installs), therefore go
the 30+ years common practise way and introduce MANDIR environment variable.
Since it's a subdir under the prefix for general constant and machine
architecture independ data -- which in turn also sometimes wants to be
overridden by distros, it shall be derived from DATADIR variable.

Signed-off-by: Enrico Weigelt, metux IT consult [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @metux. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 8, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metux metux force-pushed the submit/fhs-manpage branch from 4ed0cda to fa3211c Compare June 9, 2021 17:20
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 9, 2021

Build succeeded.

FHS mandates manpages should go to /usr/share/man (or /usr/local/share/man,
for site local installations) -- /usr/man was an fallout of some ancient
Unices that haven't been fully FHS conformant and usually just a symlink to
/usr/share/man, if existing at all.

Distros sometimes need to override this (eg. MVCC installs), therefore go
the 30+ years common practise way and introduce MANDIR environment variable.
Since it's a subdir under the prefix for general constant and machine
architecture independ data -- which in turn also sometimes wants to be
overridden by distros, it shall be derived from DATADIR variable.

Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
@metux metux force-pushed the submit/fhs-manpage branch from fa3211c to 77374e8 Compare June 10, 2021 17:07
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 10, 2021

Build succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants