Skip to content

Install specific golang version in Windows CI.#5571

Merged
mxpv merged 1 commit intocontainerd:mainfrom
adelina-t:win_set_specific_go_version
Jul 2, 2021
Merged

Install specific golang version in Windows CI.#5571
mxpv merged 1 commit intocontainerd:mainfrom
adelina-t:win_set_specific_go_version

Conversation

@adelina-t
Copy link
Copy Markdown

@adelina-t adelina-t commented Jun 7, 2021 •
edited
Loading

For Periodic Windows runs we installed the latest available golang version.
It seems 1.16.5 is creating problems with go.sum. We now introduce the
ability to install specific versions for required packages when preparing
the testing env.

This was noticed after the merge of PR: #5562

Trying to run integration tests with golang v1.16.5 results in:

$ make integration
+ integration
# github.com/containerd/containerd/integration/client
..\..\container.go:40:2: missing go.sum entry for module providing package github.com/opencontainers/selinux/go-selinux/label (imported by github.com/containerd/containerd); to add:
        go get github.com/containerd/[email protected]
FAIL    github.com/containerd/containerd/integration/client [setup failed]
make: *** [Makefile:192: integration] Error 1

The usual suspects like go mod tidy do not work.

Every other version up until and including v1.16.4 works.

Signed-off-by: Adelina Tuvenie [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jun 7, 2021

Hi @adelina-t. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 7, 2021

Build succeeded.

@adelina-t
Copy link
Copy Markdown
Author

adelina-t commented Jun 7, 2021

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims June 7, 2021 11:05
Install specific golang version in Windows CI.
419d616 
For Periodic Windows runs we installed the latest available golang version.
It seems 1.16.5 is creating problems with go.sum. We now introduce the
ability to install specific versions for required packages when preparing
the testing env.

Signed-off-by: Adelina Tuvenie <[email protected]>
@adelina-t adelina-t force-pushed the win_set_specific_go_version branch from 10df9ce to 419d616 Compare June 7, 2021 12:17
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 7, 2021

Build succeeded.

@dims
Copy link
Copy Markdown
Member

dims commented Jun 7, 2021

@adelina-t can you try go mod vendor in the integration/client directory and see if that modifies the go.mod/go.sum in that directory? (and if that fixes the problem?)

@adelina-t
Copy link
Copy Markdown
Author

adelina-t commented Jun 7, 2021

@adelina-t can you try go mod vendor in the integration/client directory and see if that modifies the go.mod/go.sum in that directory? (and if that fixes the problem?)

Tried that, did not work for me on that env, nothing changed. I’ll check on a clean env, to be sure.

@dims
Copy link
Copy Markdown
Member

dims commented Jun 7, 2021

@adelina-t see https://github.com/containerd/containerd/pull/5572/commits please

@adelina-t
Copy link
Copy Markdown
Author

adelina-t commented Jun 7, 2021

@adelina-t see https://github.com/containerd/containerd/pull/5572/commits please

cool! In any case, I’ll leave this open, having the ability to set version of dependencies should be introduced at some point.

@kzys
Copy link
Copy Markdown
Member

kzys commented Jun 15, 2021

/ok-to-test

@kzys
Copy link
Copy Markdown
Member

kzys commented Jul 2, 2021

@containerd/committers Can someone take a look and merge this PR?

@mxpv mxpv merged commit 7eceeb9 into containerd:main Jul 2, 2021
bainss pushed a commit to bainss/containerd that referenced this pull request Jul 10, 2021
@mxpv @bainss
Merge pull request containerd#5571 from adelina-t/win_set_specific_go…
b4cb68c 
…_version

Install specific golang version in Windows CI.

Signed-off-by: Surjit Bains <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@crosbymichael crosbymichael crosbymichael approved these changes

@mxpv mxpv mxpv approved these changes

@dims dims Awaiting requested review from dims

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adelina-t @k8s-ci-robot @dims @kzys @crosbymichael @mxpv