Fix cleanup context of teardownPodNetwork#5569
Conversation
Similar to other deferred cleanup operations, teardownPodNetwork should use a different context as the original context may have expired, otherwise CNI wouldn't been invoked, leading to leak of network resources, e.g. IP addresses. Signed-off-by: Quan Tian <[email protected]>
|
Hi @tnqn. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
We saw IP addresses were leaked when using Containerd 1.4.4 and Antrea as the CNI, the symptom is that containerd cannot create sandbox container successfully after running a while, failed because of the error: The reason that it failed to start sandbox container task may be opencontainers/runc#2865 and may have been fixed by opencontainers/runc#2871. |
|
Build succeeded.
|
|
/ok-to-test |
|
@fuweid let's make sure k8s CI jobs go green as well. |
[release/1.5] cherry pick #5569 to release 1.5 - Fix cleanup context of teardownPodNetwork
Similar to other deferred cleanup operations, teardownPodNetwork should use a different context as the original context may have expired, otherwise CNI wouldn't been invoked, leading to leak of network resources, e.g. IP addresses.
Signed-off-by: Quan Tian [email protected]
Fixes #5438