Skip to content

Windows periodic job: Add creation timestamp to RG#5559

Merged
estesp merged 1 commit intocontainerd:masterfrom
adelina-t:win_rg_creation_timestamp
Jun 3, 2021
Merged

Windows periodic job: Add creation timestamp to RG#5559
estesp merged 1 commit intocontainerd:masterfrom
adelina-t:win_rg_creation_timestamp

Conversation

@adelina-t
Copy link
Copy Markdown

When creating a resource group in Azure for the Windows Periodic Job, we need to tag it with a timestamp so that the automatic cleanup tool will not delete the RG mid run.

Signed-off-by: Adelina Tuvenie [email protected]

Signed-off-by: Adelina Tuvenie <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @adelina-t. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jun 2, 2021

Build succeeded.

@adelina-t
Copy link
Copy Markdown
Author

Fixes: #5549

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .github/workflows/windows-periodic.yml
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

/ok-to-test

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit e3521ed into containerd:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants