Do not run btrfs tests if btrfs kernel module is not loaded#5539
Do not run btrfs tests if btrfs kernel module is not loaded#5539dmcgowan merged 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Alakesh Haloi <[email protected]>
|
Hi @alakesh. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
|
/ok-to-test |
|
|
||
| // TODO: Check for btrfs in /proc/module and skip if not loaded | ||
| procModules, err := ioutil.ReadFile("/proc/modules") | ||
| if err == nil && !bytes.Contains(procModules, []byte("btrfs")) { |
There was a problem hiding this comment.
Considering procModules is already a string, why use bytes.Contains instead of strings.Contains?
There was a problem hiding this comment.
Readfile function returns a []byte type hence thought of using it like that. Could also convert it to a string and then use strings.Contain() but both approaches look similar.
4 participants
Check if btrfs module is loaded. if not do not run btrfs test.
Signed-off-by: Alakesh Haloi [email protected]