Skip to content

Makefile: allow overriding install command via environment#5493

Merged
estesp merged 1 commit intocontainerd:masterfrom
oss-qm:submit/install-prog
May 18, 2021
Merged

Makefile: allow overriding install command via environment#5493
estesp merged 1 commit intocontainerd:masterfrom
oss-qm:submit/install-prog

Conversation

@metux
Copy link
Copy Markdown
Contributor

@metux metux commented May 12, 2021

Packaging systems often want to override the install(1) command via INSTALL
environment variable, in order to do distro specific fixups (eg. splitting
out debug symbols from binaries to separate files).

Also use it for creating install target directories.

Signed-off-by: Enrico Weigelt, metux IT consult [email protected]

Packaging systems often want to override the install(1) command via INSTALL
environment variable, in order to do distro specific fixups (eg. splitting
out debug symbols from binaries to separate files).

Also use it for creating install target directories.

Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @metux. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented May 12, 2021

Build succeeded.

Copy link
Copy Markdown
Contributor

@alakesh alakesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread Makefile

define installmanpage
mkdir -p $(DESTDIR)/man/man$(2);
$(INSTALL) -d $(DESTDIR)/man/man$(2);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to other curious reviewers: install's -d flag is not GNU-only. It is supported by FreeBSD as well.

Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

/ok-to-test

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 49321a1 into containerd:master May 18, 2021
@metux metux deleted the submit/install-prog branch May 25, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants