integration: Adds resource limit tests by claudiubelu · Pull Request #5485 · containerd/containerd

claudiubelu · 2021-05-11T15:23:25Z

Moves TestUpdateContainerResources_MemorySwap and associated functions to container_update_resources_linux_test.go. They are Linux-specific, requiring cgroups. We're doing this in order to allow the other tests to have Windows support afterwards.

Adds Windows support to the TestUpdateContainerResources_MemoryLimit test.

Adds test that ensure the CPU limits on the containers can be updated and are enforced.

Signed-off-by: Claudiu Belu [email protected]

theopenlab-ci · 2021-05-11T15:23:33Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

k8s-ci-robot · 2021-05-11T15:23:33Z

Hi @claudiubelu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2021-05-11T16:00:12Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 44s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 31s (non-voting)
containerd-integration-test-arm64 : FAILURE in 19m 22s (non-voting)

theopenlab-ci · 2021-05-17T16:14:59Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 42s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 33s (non-voting)
containerd-integration-test-arm64 : FAILURE in 22m 40s (non-voting)

theopenlab-ci · 2021-05-17T18:03:28Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 46s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 30s (non-voting)
containerd-integration-test-arm64 : FAILURE in 22m 38s (non-voting)

theopenlab-ci · 2021-05-17T19:14:59Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 47s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 29s (non-voting)
containerd-integration-test-arm64 : FAILURE in 22m 28s (non-voting)

theopenlab-ci · 2021-05-18T11:19:25Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 50s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 33s (non-voting)
containerd-integration-test-arm64 : FAILURE in 22m 56s (non-voting)

theopenlab-ci · 2021-05-18T14:07:38Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 43s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 23s (non-voting)
containerd-integration-test-arm64 : FAILURE in 23m 04s (non-voting)

theopenlab-ci · 2021-05-18T14:38:42Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 48s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 29s (non-voting)
containerd-integration-test-arm64 : FAILURE in 23m 07s (non-voting)

theopenlab-ci · 2021-05-19T11:00:49Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 41s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 29s (non-voting)
containerd-integration-test-arm64 : FAILURE in 22m 37s (non-voting)

theopenlab-ci · 2021-05-19T13:30:00Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 40s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 40s (non-voting)
containerd-integration-test-arm64 : FAILURE in 23m 28s (non-voting)

theopenlab-ci · 2021-05-19T14:18:26Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 42s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 29s (non-voting)
containerd-integration-test-arm64 : FAILURE in 23m 29s (non-voting)

theopenlab-ci · 2021-05-19T14:57:54Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 44s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 32s (non-voting)
containerd-integration-test-arm64 : FAILURE in 22m 57s (non-voting)

theopenlab-ci · 2021-08-01T12:35:50Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 38s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 18s (non-voting)
containerd-integration-test-arm64 : FAILURE in 24m 06s (non-voting)

theopenlab-ci · 2021-08-04T14:33:59Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 31s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 22s (non-voting)
containerd-integration-test-arm64 : FAILURE in 24m 12s (non-voting)

theopenlab-ci · 2021-08-04T20:45:45Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 3m 59s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 17s (non-voting)
containerd-integration-test-arm64 : FAILURE in 29m 21s (non-voting)

claudiubelu · 2021-08-11T10:29:42Z

To a certain degree your test contribution combines some elements of existing integration tests into a new integration bucket (see container_stats_test, container_update_resources_test, ...). Was there an issue we are tracking/resolving that we can review this against?

Updated a few things and based everything else on the container_update_resources_test.go. This now enables those tests to run for Windows as well, and adds tests for CPU limits.

The plan was to add Windows support for this from the start (#5163), but we couldn't at that time as we were waiting for a few things to get resolved first. Now, we need this to merge too: #5778

theopenlab-ci · 2021-09-13T12:35:13Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 51s (non-voting)
containerd-test-arm64 : SUCCESS in 6m 03s (non-voting)
containerd-integration-test-arm64 : FAILURE in 16m 21s (non-voting)

theopenlab-ci · 2021-09-14T13:24:46Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 21s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 29s (non-voting)
containerd-integration-test-arm64 : FAILURE in 16m 14s (non-voting)

theopenlab-ci · 2021-09-15T08:37:45Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 03s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 26s (non-voting)
containerd-integration-test-arm64 : FAILURE in 24m 52s (non-voting)

theopenlab-ci · 2021-09-15T13:14:52Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 55s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 41s (non-voting)
containerd-integration-test-arm64 : FAILURE in 29m 25s (non-voting)

theopenlab-ci · 2021-09-16T07:51:57Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 31s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 26s (non-voting)
containerd-integration-test-arm64 : FAILURE in 24m 18s (non-voting)

theopenlab-ci · 2021-10-04T11:19:02Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 52s (non-voting)
containerd-test-arm64 : SUCCESS in 6m 01s (non-voting)
containerd-integration-test-arm64 : FAILURE in 24m 13s (non-voting)

theopenlab-ci · 2021-10-18T14:57:43Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 19s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 30s (non-voting)
containerd-integration-test-arm64 : FAILURE in 25m 03s (non-voting)

Moves TestUpdateContainerResources_MemorySwap and associated functions to container_update_resources_linux_test.go. They are Linux-specific, requiring cgroups. We're doing this in order to allow the other tests to have Windows support afterwards. Signed-off-by: Claudiu Belu <[email protected]>

Adds Windows support to the TestUpdateContainerResources_MemoryLimit test. Adds test that ensure the CPU limits on the containers can be updated and are enforced. Signed-off-by: Claudiu Belu <[email protected]>

theopenlab-ci · 2022-01-03T09:43:07Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 4m 23s (non-voting)
containerd-test-arm64 : SUCCESS in 5m 37s (non-voting)
containerd-integration-test-arm64 : SUCCESS in 21m 27s (non-voting)

dmcgowan · 2023-04-17T21:48:27Z

Closing due to inactivity, feel free to re-open the pull request anytime if you continue working on this.

k8s-ci-robot added the needs-ok-to-test label May 11, 2021

claudiubelu force-pushed the integration/resource-limits branch 2 times, most recently from d0be410 to 7c54c16 Compare May 11, 2021 15:38

AkihiroSuda reviewed May 11, 2021

View reviewed changes

Comment thread integration/container_limits_test.go Outdated

claudiubelu force-pushed the integration/resource-limits branch 2 times, most recently from a945b53 to 84d6d4a Compare May 17, 2021 15:50

claudiubelu force-pushed the integration/resource-limits branch from 84d6d4a to d533558 Compare May 17, 2021 17:39

claudiubelu force-pushed the integration/resource-limits branch from d533558 to d529779 Compare May 17, 2021 18:50

claudiubelu force-pushed the integration/resource-limits branch from d529779 to c177fa2 Compare May 18, 2021 10:54

claudiubelu force-pushed the integration/resource-limits branch from c177fa2 to 8f62430 Compare May 18, 2021 13:42

claudiubelu changed the title ~~WIP: integration: Adds resource limit tests~~ integration: Adds resource limit tests May 18, 2021

claudiubelu force-pushed the integration/resource-limits branch from 8f62430 to a837007 Compare May 18, 2021 14:13

claudiubelu force-pushed the integration/resource-limits branch 2 times, most recently from 2c489e5 to 675ca50 Compare May 19, 2021 10:36

claudiubelu force-pushed the integration/resource-limits branch from 675ca50 to 1af9ce7 Compare May 19, 2021 13:04

claudiubelu force-pushed the integration/resource-limits branch from 1af9ce7 to 6feb1de Compare May 19, 2021 13:53

claudiubelu force-pushed the integration/resource-limits branch from 6feb1de to 3fd77b4 Compare May 19, 2021 14:32

claudiubelu force-pushed the integration/resource-limits branch from 292ebc1 to 1ce837f Compare August 1, 2021 12:10

claudiubelu force-pushed the integration/resource-limits branch from 1ce837f to 7ecbc6e Compare August 4, 2021 14:08

claudiubelu force-pushed the integration/resource-limits branch from 7ecbc6e to 130e8b7 Compare August 4, 2021 20:14

claudiubelu changed the title ~~WIP: integration: Adds resource limit tests~~ integration: Adds resource limit tests Aug 11, 2021

claudiubelu mentioned this pull request Aug 23, 2021

Windows: Cannot Update Container Resources on Running Container. #5169

Closed

claudiubelu force-pushed the integration/resource-limits branch from 130e8b7 to 7037aa3 Compare September 13, 2021 12:17

claudiubelu force-pushed the integration/resource-limits branch from 7037aa3 to 39c9b17 Compare September 14, 2021 13:05

claudiubelu force-pushed the integration/resource-limits branch from 39c9b17 to 80ae954 Compare September 15, 2021 08:11

claudiubelu force-pushed the integration/resource-limits branch from 80ae954 to 1219cb4 Compare September 15, 2021 12:43

claudiubelu force-pushed the integration/resource-limits branch from 1219cb4 to ba38010 Compare September 16, 2021 07:25

claudiubelu force-pushed the integration/resource-limits branch from ba38010 to 2221239 Compare October 4, 2021 10:53

claudiubelu force-pushed the integration/resource-limits branch from 2221239 to 18f0373 Compare October 18, 2021 14:31

claudiubelu force-pushed the integration/resource-limits branch from 18f0373 to 3f5d965 Compare January 3, 2022 08:53

claudiubelu added 2 commits January 3, 2022 01:19

integration: Adds Windows resource limit tests

92da520

Adds Windows support to the TestUpdateContainerResources_MemoryLimit test. Adds test that ensure the CPU limits on the containers can be updated and are enforced. Signed-off-by: Claudiu Belu <[email protected]>

claudiubelu force-pushed the integration/resource-limits branch from 3f5d965 to 92da520 Compare January 3, 2022 09:20

dmcgowan closed this Apr 17, 2023

Conversation

claudiubelu commented May 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theopenlab-ci Bot commented May 11, 2021

Uh oh!

k8s-ci-robot commented May 11, 2021

Uh oh!

theopenlab-ci Bot commented May 11, 2021

Uh oh!

Uh oh!

theopenlab-ci Bot commented May 17, 2021

Uh oh!

theopenlab-ci Bot commented May 17, 2021

Uh oh!

theopenlab-ci Bot commented May 17, 2021

Uh oh!

theopenlab-ci Bot commented May 18, 2021

Uh oh!

theopenlab-ci Bot commented May 18, 2021

Uh oh!

theopenlab-ci Bot commented May 18, 2021

Uh oh!

theopenlab-ci Bot commented May 19, 2021

Uh oh!

theopenlab-ci Bot commented May 19, 2021

Uh oh!

theopenlab-ci Bot commented May 19, 2021

Uh oh!

theopenlab-ci Bot commented May 19, 2021

Uh oh!

theopenlab-ci Bot commented Aug 1, 2021

Uh oh!

theopenlab-ci Bot commented Aug 4, 2021

Uh oh!

theopenlab-ci Bot commented Aug 4, 2021

Uh oh!

claudiubelu commented Aug 11, 2021

Uh oh!

theopenlab-ci Bot commented Sep 13, 2021

Uh oh!

theopenlab-ci Bot commented Sep 14, 2021

Uh oh!

theopenlab-ci Bot commented Sep 15, 2021

Uh oh!

theopenlab-ci Bot commented Sep 15, 2021

Uh oh!

theopenlab-ci Bot commented Sep 16, 2021

Uh oh!

theopenlab-ci Bot commented Oct 4, 2021

Uh oh!

theopenlab-ci Bot commented Oct 18, 2021

Uh oh!

theopenlab-ci Bot commented Jan 3, 2022

Uh oh!

dmcgowan commented Apr 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

claudiubelu commented May 11, 2021 •

edited

Loading