Skip to content

tests: add test for adaptor#5452

Merged
estesp merged 1 commit intocontainerd:masterfrom
Dentrax:feature/add-test-for-adaptor
May 7, 2021
Merged

tests: add test for adaptor#5452
estesp merged 1 commit intocontainerd:masterfrom
Dentrax:feature/add-test-for-adaptor

Conversation

@Dentrax
Copy link
Copy Markdown
Contributor

@Dentrax Dentrax commented May 4, 2021

I noticed AdaptInfo missing test cases. I think this func a bit important to test since we use this func in other packages like content, store (walking), etc.

Signed-off-by: Furkan Turkal [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 4, 2021

Hi @Dentrax. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented May 4, 2021

Build succeeded.

@Dentrax Dentrax force-pushed the feature/add-test-for-adaptor branch from c9e1c2e to b36b097 Compare May 5, 2021 07:23
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented May 5, 2021

Build succeeded.

@estesp
Copy link
Copy Markdown
Member

estesp commented May 5, 2021

/ok-to-test

@estesp
Copy link
Copy Markdown
Member

estesp commented May 5, 2021

All files need to have the standard file header with license/copyright; feel free to copy it from another file

@Dentrax
tests: add test for adaptor
7d70992 
I noticed AdaptInfo missing test cases. I think this
func a bit important to test since we use this func
in other packages like content, store (walking), etc.

Signed-off-by: Furkan Turkal <[email protected]>
Signed-off-by: Furkan <[email protected]>
@Dentrax Dentrax force-pushed the feature/add-test-for-adaptor branch from b36b097 to 7d70992 Compare May 5, 2021 14:40
@Dentrax
Copy link
Copy Markdown
Contributor Author

Dentrax commented May 5, 2021 •
edited
Loading

All files need to have the standard file header with license/copyright; feel free to copy it from another file

Oh, forgot to add, done. Maybe we can use addlicense to ensure licenses are included at the top of the files. i.e.:

$ addlicense -l apache -c 'The containerd Authors' -v *

Wdyt?

@estesp
Copy link
Copy Markdown
Member

estesp commented May 5, 2021

We already use ltag in the CI pipeline to validate :)

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented May 5, 2021

Build succeeded.

estesp
estesp approved these changes May 5, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 01ca105 into containerd:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dentrax @k8s-ci-robot @estesp @kzys