doc: add missing namespaces package#5448
Conversation
|
Hi @Dentrax. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Dentrax
force-pushed
the
fix/doc-client-import
branch
2 times, most recently
from
73d48d8 to
8172487
Compare
|
Build succeeded.
|
Please sign with full name |
Dentrax
force-pushed
the
fix/doc-client-import
branch
from
8172487 to
e2f2ba4
Compare
|
Build succeeded.
|
There was a problem hiding this comment.
Maybe, we should add import "github.com/containerd/containerd/namespaces" and import context here:
There was a problem hiding this comment.
Thanks, forgot to add context here. I added at top of the imports.
Dentrax
force-pushed
the
fix/doc-client-import
branch
from
e2f2ba4 to
32c66e7
Compare
|
Build succeeded.
|
Currently, we can not reproduce the given Namespaces section examples written in the README, since it's not clear to which package should we import to. Signed-off-by: Furkan Turkal <[email protected]>
Dentrax
force-pushed
the
fix/doc-client-import
branch
from
32c66e7 to
0b78690
Compare
|
Build succeeded.
|
5 participants
Currently, we can not reproduce the given Namespaces section examples written in the README, since it's not clear to which package should we import to.
Signed-off-by: Furkan Turkal [email protected]