Skip to content

Update golang.org/x/sys to add linux/ppc support#5436

Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom
bwh-mind:ppc32
May 4, 2021
Merged

Update golang.org/x/sys to add linux/ppc support#5436
AkihiroSuda merged 1 commit intocontainerd:masterfrom
bwh-mind:ppc32

Conversation

@bwh-mind
Copy link
Copy Markdown
Contributor

@bwh-mind bwh-mind commented Apr 29, 2021 •
edited
Loading

This package was recently updated to add support for Linux on
32-bit PowerPC (ppc), implemented by gccgo.

Signed-off-by: Ben Hutchings [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 29, 2021

Hi @bwh-mind. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 29, 2021

Build succeeded.

estesp
estesp approved these changes Apr 30, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; seems fine, but I think given where we are in the 1.5.0 release cycle we should wait on vendor update until after release

@estesp
Copy link
Copy Markdown
Member

estesp commented Apr 30, 2021

/ok-to-test

@estesp estesp added this to the 1.6 milestone Apr 30, 2021
@bwh-mind
Copy link
Copy Markdown
Contributor Author

bwh-mind commented Apr 30, 2021

The CI failure on Windows looks like a temporary network issue.

@bwh-mind
Update golang.org/x/sys to add linux/ppc support
b538d8f 
This package as recently updated to add support for Linux on
32-bit PowerPC (ppc), implemented by gccgo.

Signed-off-by: Ben Hutchings <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented May 2, 2021

Build succeeded.

@AkihiroSuda AkihiroSuda modified the milestones: 1.6, 1.5.1 May 3, 2021
kzys
kzys approved these changes May 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can we have a PowerPC build in our CI setup?

mikebrow
mikebrow approved these changes May 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit c27cbc6 into containerd:master May 4, 2021
@thaJeztah thaJeztah mentioned this pull request Jul 20, 2021
Closed
@thaJeztah thaJeztah added cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch and removed cherry-pick/1.5.x labels Jul 20, 2021
@kzys kzys mentioned this pull request Mar 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch ok-to-test

Projects

None yet

Milestone

1.5.1

Development

Successfully merging this pull request may close these issues.

7 participants

@bwh-mind @k8s-ci-robot @estesp @kzys @AkihiroSuda @mikebrow @thaJeztah