CI: allow Go 1.13 for Docker/Moby compatibility#5431
CI: allow Go 1.13 for Docker/Moby compatibility#5431crosbymichael merged 1 commit intocontainerd:masterfrom
Conversation
Docker/Moby still uses Go 1.13 for building containerd binaries. Signed-off-by: Akihiro Suda <[email protected]>
|
Build succeeded.
|
| go-version: ['1.16.3'] | ||
| include: | ||
| # Go 1.13.x is still used by Docker/Moby | ||
| - go-version: '1.13.x' |
There was a problem hiding this comment.
when 1.18 drops (generics) n-3 will become problematic..
There was a problem hiding this comment.
Sorry what do you mean?
There was a problem hiding this comment.
There is a language change for go called generics. It is currently planned for v1.18... if/when that happens we'll have to decide if we allow the use of said feature or if we will forego using it to help out the people who are not moving up.
There was a problem hiding this comment.
Ah, I was expecting generics to be in Go 2.0 👀
We will have to help Moby-related repos to migrate to the latest Go before that...
There was a problem hiding this comment.
My impression is there won't be an actual go2.0 release, and the "go 2" project is more about driving the language forwards through 1.x releases.
6 participants
Docker/Moby still uses Go 1.13 for building containerd binaries.