Skip to content

tests: Adds consumed memory stats test#5427

Merged
estesp merged 1 commit intocontainerd:masterfrom
claudiubelu:tests/measure-consumed-stats
Apr 29, 2021
Merged

tests: Adds consumed memory stats test#5427
estesp merged 1 commit intocontainerd:masterfrom
claudiubelu:tests/measure-consumed-stats

Conversation

@claudiubelu
Copy link
Copy Markdown
Contributor

@claudiubelu claudiubelu commented Apr 27, 2021

We can check that the reported containers stats are not lower than it should by using the resource-consumer image. This image contains stress / testlimit.exe which can consume a specified amount of memory.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 27, 2021

Hi @claudiubelu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 27, 2021

Build succeeded.

@mxpv
Copy link
Copy Markdown
Member

mxpv commented Apr 27, 2021

Could you please sign off your commits (try git commit -s) in order to pass CI checks?
https://github.com/containerd/project/blob/master/CONTRIBUTING.md#sign-your-work

@claudiubelu claudiubelu force-pushed the tests/measure-consumed-stats branch 2 times, most recently from 189126f to fda8ff6 Compare April 28, 2021 08:33
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 28, 2021

Build succeeded.

@claudiubelu claudiubelu force-pushed the tests/measure-consumed-stats branch 2 times, most recently from e74eff8 to 05b91a8 Compare April 28, 2021 09:13
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 28, 2021

Build succeeded.

@claudiubelu claudiubelu force-pushed the tests/measure-consumed-stats branch from 05b91a8 to d3e4d73 Compare April 28, 2021 09:42
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 28, 2021

Build succeeded.

estesp
estesp approved these changes Apr 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikebrow
mikebrow reviewed Apr 28, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question about the need for 1GB..

Comment thread integration/container_stats_test.go Outdated
@kzys
Copy link
Copy Markdown
Member

kzys commented Apr 28, 2021

/ok-to-test

@claudiubelu claudiubelu force-pushed the tests/measure-consumed-stats branch from d3e4d73 to 2f92594 Compare April 29, 2021 13:55
estesp
estesp reviewed Apr 29, 2021
View reviewed changes
Comment thread integration/container_stats_test.go Outdated
@claudiubelu
tests: Adds consumed memory stats test
3187b6d 
We can check that the reported containers stats are not lower than it should
by using the resource-consumer image. This image contains stress / testlimit.exe
which can consume a specified amount of memory.

Signed-off-by: Claudiu Belu <[email protected]>
@claudiubelu claudiubelu force-pushed the tests/measure-consumed-stats branch from 2f92594 to 3187b6d Compare April 29, 2021 14:11
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 29, 2021

Build succeeded.

estesp
estesp approved these changes Apr 29, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 4196fb2 into containerd:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikebrow mikebrow mikebrow left review comments

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@claudiubelu @k8s-ci-robot @mxpv @kzys @estesp @mikebrow