Skip to content

Use the multi-arch versions of the test images#5421

Merged
estesp merged 1 commit intocontainerd:masterfrom
dims:use-the-multi-arch-versions-of-test-images
Apr 26, 2021
Merged

Use the multi-arch versions of the test images#5421
estesp merged 1 commit intocontainerd:masterfrom
dims:use-the-multi-arch-versions-of-test-images

Conversation

@dims
Copy link
Copy Markdown
Member

@dims dims commented Apr 24, 2021

Follow up to #5416, We need to push those images first and then merge this change

Signed-off-by: Davanum Srinivas [email protected]

@dims dims added this to the 1.5 milestone Apr 24, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 24, 2021

Build succeeded.

@AkihiroSuda
Copy link
Copy Markdown
Member

volume_copy_up_test.go:111: 290 Error Trace: volume_copy_up_test.go:111 291 Error: Received unexpected error: 292 rpc error: code = NotFound desc = failed to pull and unpack image "gcr.io/k8s-cri-containerd/volume-ownership:2.0": failed to resolve reference "gcr.io/k8s-cri-containerd/volume-ownership:2.0": gcr.io/k8s-cri-containerd/volume-ownership:2.0: not found 293 Test: TestVolumeOwnership 294 --- FAIL: TestVolumeOwnership (2.26s)

@AkihiroSuda AkihiroSuda marked this pull request as draft April 24, 2021 13:40
volume-copy-up:2.0 and volume-ownership:2.0

Signed-off-by: Davanum Srinivas <[email protected]>
@dims dims force-pushed the use-the-multi-arch-versions-of-test-images branch from 8843d79 to 2e4c1d4 Compare April 25, 2021 21:50
@dims dims requested review from estesp and mikebrow April 25, 2021 21:50
@dims dims marked this pull request as ready for review April 25, 2021 21:51
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 25, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 04f73e3 into containerd:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants