Skip to content

New Openlab based job to run ARM64 tests#5406

Merged
mikebrow merged 2 commits intocontainerd:masterfrom
dims:separate-jobs-for-build-and-test-for-openlab
Apr 23, 2021
Merged

New Openlab based job to run ARM64 tests#5406
mikebrow merged 2 commits intocontainerd:masterfrom
dims:separate-jobs-for-build-and-test-for-openlab

Conversation

@dims
Copy link
Copy Markdown
Member

@dims dims commented Apr 22, 2021 •
edited
Loading

Running the following tests:

make test
make root-test
make integration EXTRA_TESTFLAGS=-no-criu TESTFLAGS_RACE=-race
TESTFLAGS_PARALLEL=1 make integration EXTRA_TESTFLAGS=-no-criu
CONTAINERD_RUNTIME="io.containerd.runc.v2" make cri-integration

Should be easy to add more as needed or break this into multiple jobs.

NOTE: some tests are failing.

Signed-off-by: Davanum Srinivas [email protected]

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 22, 2021

Build succeeded.

@dims dims force-pushed the separate-jobs-for-build-and-test-for-openlab branch from 16c2d5e to 2b0e6cd Compare April 22, 2021 11:21
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 22, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 22, 2021

Build succeeded.

@dims dims force-pushed the separate-jobs-for-build-and-test-for-openlab branch from 2750087 to bead942 Compare April 22, 2021 13:27
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 22, 2021

Build succeeded.

@dims dims force-pushed the separate-jobs-for-build-and-test-for-openlab branch from bead942 to 1fa39fe Compare April 22, 2021 13:54
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 22, 2021

Build succeeded.

@dims dims force-pushed the separate-jobs-for-build-and-test-for-openlab branch from 1fa39fe to 7d42d06 Compare April 22, 2021 14:50
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 22, 2021

Build succeeded.

@dims dims force-pushed the separate-jobs-for-build-and-test-for-openlab branch from 7d42d06 to 34aac4e Compare April 22, 2021 15:09
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 22, 2021

Build succeeded.

@dims dims force-pushed the separate-jobs-for-build-and-test-for-openlab branch from 34aac4e to f39c40b Compare April 22, 2021 16:04
@dims dims mentioned this pull request Apr 22, 2021
Merged
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 22, 2021

Build succeeded.

@dims dims force-pushed the separate-jobs-for-build-and-test-for-openlab branch from f39c40b to 99f1c1a Compare April 22, 2021 16:44
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 22, 2021

Build succeeded.

@dims dims changed the title [WIP] Separate jobs for build and test for openlab/arm64 New Openlab based job to run ARM64 tests Apr 22, 2021
estesp
estesp approved these changes Apr 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very nice @dims!

mikebrow
mikebrow approved these changes Apr 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just a couple nits...

Comment thread .zuul/playbooks/containerd-build/integration-test.yaml Outdated
Comment thread .zuul/playbooks/containerd-build/integration-test.yaml Outdated
@dims
add integration tests
78e5297 
Signed-off-by: Davanum Srinivas <[email protected]>
@dims dims force-pushed the separate-jobs-for-build-and-test-for-openlab branch from 99f1c1a to 78e5297 Compare April 23, 2021 00:53
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 23, 2021

Build succeeded.

@dims
Copy link
Copy Markdown
Member Author

dims commented Apr 23, 2021

This is ready now @mikebrow !

@dims dims mentioned this pull request Apr 23, 2021
Closed
@dims
Copy link
Copy Markdown
Member Author

dims commented Apr 23, 2021

@hakman one follow up is here #5409

estesp
estesp approved these changes Apr 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikebrow
mikebrow approved these changes Apr 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit 9cf44ee into containerd:master Apr 23, 2021
@estesp estesp mentioned this pull request May 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

+1 more reviewer

@hakman hakman hakman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dims @kzys @estesp @hakman @mikebrow