tests: Refactors container image usage#5403
Merged
estesp merged 1 commit intocontainerd:masterfrom Apr 27, 2021
Merged
Conversation
claudiubelu
force-pushed
the
cri-integration-images
branch
from
ccd0a7a to
8bf56b2
Compare
Closed
kzys
approved these changes
Apr 21, 2021
Member
|
/ok-to-test |
mxpv
reviewed
Apr 21, 2021
This was referenced Apr 21, 2021
claudiubelu
force-pushed
the
cri-integration-images
branch
from
8bf56b2 to
7cd22c1
Compare
kzys
reviewed
Apr 21, 2021
claudiubelu
force-pushed
the
cri-integration-images
branch
from
7cd22c1 to
40d8b9d
Compare
kzys
approved these changes
Apr 22, 2021
claudiubelu
force-pushed
the
cri-integration-images
branch
from
40d8b9d to
46e8182
Compare
mikebrow
reviewed
Apr 22, 2021
claudiubelu
force-pushed
the
cri-integration-images
branch
3 times, most recently
from
82893ce to
6d11b40
Compare
mxpv
reviewed
Apr 23, 2021
claudiubelu
force-pushed
the
cri-integration-images
branch
from
6d11b40 to
a7692ba
Compare
claudiubelu
force-pushed
the
cri-integration-images
branch
from
a7692ba to
355b63d
Compare
estesp
requested changes
Apr 23, 2021
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
I didn't notice your defaults didn't have :latest on the alpine and busybox entries; causing CRI test failures because it doesn't auto-resolve to use "latest" if untagged ref.
estesp
reviewed
Apr 23, 2021
claudiubelu
force-pushed
the
cri-integration-images
branch
2 times, most recently
from
34cc7a1 to
46393e5
Compare
claudiubelu
force-pushed
the
cri-integration-images
branch
from
09afdeb to
b1c0491
Compare
Contributor
Author
|
Failure is unrelated. |
claudiubelu
force-pushed
the
cri-integration-images
branch
from
b1c0491 to
d3eda06
Compare
Currently, the cri-integration tests do not work on Windows due to various reasons. One of the reasons is because all the tests are using Linux-specific images. This commit refactors the image pulling / usage in the cri-integration tests, making it easier to update, and easier to configure the a custom registry to pull those images from. For Windows runs, custom registries can be created, which will also contain Windows images, and the cri-integration tests can be configured to use those registries by specifying the "--image-list" argument, a TOML file which will contain an alternative mapping of the default images. Signed-off-by: Claudiu Belu <[email protected]>
claudiubelu
force-pushed
the
cri-integration-images
branch
from
d3eda06 to
5847340
Compare
Contributor
Author
|
/test pull-containerd-node-e2e |
2 similar comments
Contributor
Author
|
/test pull-containerd-node-e2e |
Member
|
/test pull-containerd-node-e2e |
Contributor
Author
|
recheck |
|
Build succeeded.
|
Member
|
/test pull-containerd-node-e2e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
cri-integrationtests do not work on Windows due to various reasons. One of the reasons is because all the tests are using Linux-specific images. This commit refactors the image pulling / usage in thecri-integrationtests, making iteasier to update, and easier to configure the a custom registry to pull those images from.
For Windows runs, custom registries can be created, which will also contain Windows images, and the
cri-integrationtests can be configured to use those registries by specifying the--image-listargument, a YAML file which will contain an alternativemapping of the default images.
Signed-off-by: Claudiu Belu [email protected]