Skip to content

process: use the unbuffered channel as the done signal#5401

Merged
mxpv merged 1 commit intocontainerd:masterfrom
Iceber:use-unbuffered-channel
Apr 21, 2021
Merged

process: use the unbuffered channel as the done signal#5401
mxpv merged 1 commit intocontainerd:masterfrom
Iceber:use-unbuffered-channel

Conversation

@Iceber
Copy link
Copy Markdown
Member

@Iceber Iceber commented Apr 21, 2021 •
edited
Loading

The done is used as a signal channel to do notifications by closing, no data will be written, so done does not need to be a buffer channel.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Apr 21, 2021

Hi @Iceber. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Copy Markdown
Member

dims commented Apr 21, 2021

@Iceber can you please add details? all i see is a 1 line path with no description or context

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 21, 2021

Build succeeded.

@Iceber
Copy link
Copy Markdown
Member Author

Iceber commented Apr 21, 2021

@dims updated description

@dims
Copy link
Copy Markdown
Member

dims commented Apr 21, 2021

thanks @Iceber

@kzys
Copy link
Copy Markdown
Member

kzys commented Apr 21, 2021

/ok-to-test

stevvooe
stevvooe approved these changes Apr 21, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@stevvooe stevvooe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is never a send on this channel, so this patch is safe.

@mxpv mxpv merged commit cb64dc8 into containerd:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@stevvooe stevvooe stevvooe approved these changes

@mxpv mxpv mxpv approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Iceber @k8s-ci-robot @dims @kzys @stevvooe @mxpv