Skip to content

Prepare v1.5.0-rc.3 release notes#5400

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan:prepare-1.5.0
Apr 26, 2021
Merged

Prepare v1.5.0-rc.3 release notes#5400
dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan:prepare-1.5.0

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 20, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread releases/v1.5.0.toml Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"binaries releases" seems a bit awkward to me.

Suggested change
binaries releases. The runtimes used by containerd are maintained separately and
binary releases. The runtimes used by containerd are maintained separately and

Copy link
Copy Markdown
Member

@mikebrow mikebrow Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest: This support should be considered experimental. The runj binary is not included in this release.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a lot of trouble getting the wording right here, its more that we won't be officially releasing any builds for freebsd at this time.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Apr 21, 2021

I commented in rc.2 to mention significant changes in windows. I would like to mention it again.

It is worth to mention it in release note.

@AkihiroSuda
Copy link
Copy Markdown
Member

#### Project Organization
* **Merge containerd/cri codebased into containerd/containerd** [#4593](https://github.com/containerd/containerd/pull/4593)

s/codebased/codebase/

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
nit on explanation of runj exclusion...

@dmcgowan
Copy link
Copy Markdown
Member Author

Updated

Copy link
Copy Markdown
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 21, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Apr 23, 2021

Since #5203 has been merged, this feature should be highlighted 😂

@AkihiroSuda AkihiroSuda added this to the 1.5 milestone Apr 24, 2021
@dmcgowan
Copy link
Copy Markdown
Member Author

Updated to rc.3 to include feature merge, we can do final not long after

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 25, 2021

Build succeeded.

@AkihiroSuda AkihiroSuda changed the title Prepare v1.5.0 release notes Prepare v1.5.0-rc.3 release notes Apr 25, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 26, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit b0fb8a5 into containerd:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants