Skip to content

Use busybox from GHCR#5398

Closed
mxpv wants to merge 1 commit intocontainerd:masterfrom
mxpv:ghcr
Closed

Use busybox from GHCR#5398
mxpv wants to merge 1 commit intocontainerd:masterfrom
mxpv:ghcr

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Apr 20, 2021

I've uploaded busybox:1.32 to containerd's org container registry.
Let's give it a try in our integration tests.
This will help to offload Docker's registry.

Signed-off-by: Maksym Pavlenko [email protected]

Signed-off-by: Maksym Pavlenko <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 20, 2021

Build succeeded.

@AkihiroSuda
Copy link
Copy Markdown
Member

Shouldn't we use multi-arch image?

Cc @ktock

@mxpv mxpv marked this pull request as ready for review April 20, 2021 22:57
@mxpv
Copy link
Copy Markdown
Member Author

mxpv commented Apr 20, 2021

Yep, messed up archs somewhere. Repushed.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Apr 21, 2021

uploaded it by manually?

@mxpv
Copy link
Copy Markdown
Member Author

mxpv commented Apr 21, 2021

Yes, we don't have any automation for this.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Apr 21, 2021

Yes, we don't have any automation for this.

I was trying to upload the image by action. But I received the error like denied: installation not allowed to Create organization package. Still looking into it.

=====

check the information by manifest-tool. LGTM

manifest-tool inspect ghcr.io/containerd/busybox:1.32
Name:   ghcr.io/containerd/busybox:1.32 (Type: application/vnd.docker.distribution.manifest.list.v2+json)
Digest: sha256:ae39a6f5c07297d7ab64dbd4f82c77c874cc6a94cea29fdec309d0992574b4f7

manifest-tool inspect docker.io/library/busybox:1.32
Name:   docker.io/library/busybox:1.32 (Type: application/vnd.docker.distribution.manifest.list.v2+json)
Digest: sha256:ae39a6f5c07297d7ab64dbd4f82c77c874cc6a94cea29fdec309d0992574b4f7

Comment thread integration/main_test.go
timeout = 1 * time.Minute
pauseImage = "k8s.gcr.io/pause:3.5" // This is the same with default sandbox image.
k8sNamespace = constants.K8sContainerdNamespace
BusyBox132Image = "ghcr.io/containerd/busybox:1.32"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be just called BusyboxImage

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@estesp
Copy link
Copy Markdown
Member

estesp commented Apr 21, 2021

Not to derail this incremental change, but I noticed what @claudiubelu is doing in #5163 and almost wonder if we could break out that commit as a separate PR as it streamlines a lot of the registry definitions/image names used within the various tests.

I was thinking we might even build on that underlying support to harden our tests with an array of locations for each image (e.g. mirroring) that would be fallbacks when pull fails during the test runs on the primary image name/registry location.

@claudiubelu
Copy link
Copy Markdown
Contributor

Not to derail this incremental change, but I noticed what @claudiubelu is doing in #5163 and almost wonder if we could break out that commit as a separate PR as it streamlines a lot of the registry definitions/image names used within the various tests.

I was thinking we might even build on that underlying support to harden our tests with an array of locations for each image (e.g. mirroring) that would be fallbacks when pull fails during the test runs on the primary image name/registry location.

Sure, I can separate that. I was mirroring the way Kubernetes E2E tests handles images.

@claudiubelu
Copy link
Copy Markdown
Contributor

Not to derail this incremental change, but I noticed what @claudiubelu is doing in #5163 and almost wonder if we could break out that commit as a separate PR as it streamlines a lot of the registry definitions/image names used within the various tests.

I was thinking we might even build on that underlying support to harden our tests with an array of locations for each image (e.g. mirroring) that would be fallbacks when pull fails during the test runs on the primary image name/registry location.

Sent a PR here: #5403

@estesp
Copy link
Copy Markdown
Member

estesp commented Apr 27, 2021

It's now easy to point to different source repos for test images now that #5403 is merged; of course I haven't seen a registry rate limit in awhile now either :)

@mxpv
Copy link
Copy Markdown
Member Author

mxpv commented Apr 27, 2021

yep, i'll go ahead and close this one.

@mxpv mxpv closed this Apr 27, 2021
@mxpv mxpv deleted the ghcr branch July 16, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants