Use busybox from GHCR#5398
Conversation
Signed-off-by: Maksym Pavlenko <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
Build succeeded.
|
|
Shouldn't we use multi-arch image? Cc @ktock |
|
Yep, messed up archs somewhere. Repushed. |
|
uploaded it by manually? |
|
Yes, we don't have any automation for this. |
I was trying to upload the image by action. But I received the error like ===== check the information by manifest-tool. LGTM |
| timeout = 1 * time.Minute | ||
| pauseImage = "k8s.gcr.io/pause:3.5" // This is the same with default sandbox image. | ||
| k8sNamespace = constants.K8sContainerdNamespace | ||
| BusyBox132Image = "ghcr.io/containerd/busybox:1.32" |
There was a problem hiding this comment.
Can be just called BusyboxImage
|
Not to derail this incremental change, but I noticed what @claudiubelu is doing in #5163 and almost wonder if we could break out that commit as a separate PR as it streamlines a lot of the registry definitions/image names used within the various tests. I was thinking we might even build on that underlying support to harden our tests with an array of locations for each image (e.g. mirroring) that would be fallbacks when pull fails during the test runs on the primary image name/registry location. |
Sure, I can separate that. I was mirroring the way Kubernetes E2E tests handles images. |
Sent a PR here: #5403 |
|
It's now easy to point to different source repos for test images now that #5403 is merged; of course I haven't seen a registry rate limit in awhile now either :) |
|
yep, i'll go ahead and close this one. |
I've uploaded
busybox:1.32to containerd's org container registry.Let's give it a try in our integration tests.
This will help to offload Docker's registry.
Signed-off-by: Maksym Pavlenko [email protected]