add check quiet option and update usage #5395
Merged
crosbymichael merged 2 commits intocontainerd:masterfrom Apr 20, 2021
Merged
add check quiet option and update usage #5395crosbymichael merged 2 commits intocontainerd:masterfrom
crosbymichael merged 2 commits intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
dd15782 to
a9d2705
Compare
|
Build succeeded.
|
dmcgowan
reviewed
Apr 19, 2021
Signed-off-by: Mike Brown <[email protected]>
a9d2705 to
00f8d32
Compare
|
Build succeeded.
|
ktock
reviewed
Apr 20, 2021
Comment on lines
+224
to
+225
| log.G(ctx).Debugf("no images found") | ||
| return exitErr |
Member
There was a problem hiding this comment.
exitErr seems always nil here. Is this expected?
Member
Author
There was a problem hiding this comment.
yes.... Derek didn't think it good to return an error on no images, due I believe to the case where check is used to determine if any of the images have an issue. I used exitErr by convention in the surrounding code in case someone ever sets it non nil at some future date.
Member
There was a problem hiding this comment.
Thanks for the explanation. SGTM.
ktock
approved these changes
Apr 20, 2021
Signed-off-by: Mike Brown <[email protected]>
|
Build succeeded.
|
Member
Author
|
@dmcgowan ready for another review |
crosbymichael
approved these changes
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolving issue: #5352
check command returns errors for some cases when check fails, but not for the case when the image being checked via filter does not exist..
we should fix or.. document and maybe add another sub command for the desired check
...
After discussion with Derek decision is to document existing usage a little better, and add a -q quiet option to output only the images that are ready. Idea being that script writers can then use
wc -land check for non-zero ... etc.example outputs after changes:
Signed-off-by: Mike Brown [email protected]