go.mod: github.com/google/uuid v1.2.0#5382
Merged
mxpv merged 1 commit intocontainerd:masterfrom Apr 19, 2021
Merged
Conversation
full diff: google/uuid@v1.1.2...v1.2.0 I did not switch to us the `uuid.NewString()` function; we are not currently using `uuid.New()`, probably because it can `panic` in case an invalid UUID is produced; in stead we are using `uuid.NewRandom()`, which is equivalent, but returns an error instead. Changes: - v1.2.0: Add NewString() This release introduces the NewString() function which is the equivalent of uuid.New().String(). - v1.1.5: Syntactic cleanup There are no code changes. A missing period was add to a godoc comment and the linter was told to not complain that the results of hash.Write() are ignored (the function cannot fail) - v1.1.4: Further error optimizations Do not allocate memory for errors (it is only one word) - v1.1.3: Optimize error reporting Optimize length of time it takes to discover an input is bad by no longer using fmt.Errorf, which is quite slow. It now uses a custom error type that formats the string when the Error method is called rather than when generating the error. Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Build succeeded.
|
AkihiroSuda
approved these changes
Apr 17, 2021
samuelkarp
approved these changes
Apr 18, 2021
mxpv
approved these changes
Apr 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full diff: google/uuid@v1.1.2...v1.2.0
I did not switch to us the
uuid.NewString()function; we are not currently usinguuid.New(), probably because it canpanicin case an invalid UUID is produced;in stead we are using
uuid.NewRandom(), which is equivalent, but returns anerror instead.
Changes:
This release introduces the NewString() function which is the equivalent of
uuid.New().String().
There are no code changes. A missing period was add to a godoc comment and the
linter was told to not complain that the results of hash.Write() are ignored
(the function cannot fail)
Do not allocate memory for errors (it is only one word)
Optimize length of time it takes to discover an input is bad by no longer using
fmt.Errorf, which is quite slow. It now uses a custom error type that formats
the string when the Error method is called rather than when generating the error.