Skip to content

Remove junit test result processor#5370

Merged
mxpv merged 1 commit intocontainerd:masterfrom
cpuguy83:remove_junit_processor
Apr 15, 2021
Merged

Remove junit test result processor#5370
mxpv merged 1 commit intocontainerd:masterfrom
cpuguy83:remove_junit_processor

Conversation

@cpuguy83
Copy link
Copy Markdown
Member

This has some problems, namely that it gets confused as to what workflow
run to add results to. Related issue:
EnricoMi/publish-unit-test-result-action#12
This seems to be a shortcoming of the github API:
https://github.community/t/specify-check-suite-when-creating-a-checkrun/118380/7

This has some problems, namely that it gets confused as to what workflow
run to add results to. Related issue:
EnricoMi/publish-unit-test-result-action#12
This seems to be a shortcoming of the github API:
https://github.community/t/specify-check-suite-when-creating-a-checkrun/118380/7

Signed-off-by: Brian Goff <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 15, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@mxpv
Copy link
Copy Markdown
Member

mxpv commented Apr 15, 2021

Do we need to revert ci.yml changes too?

@github-actions
Copy link
Copy Markdown

Test Results

     13 files     219 suites   46m 22s ⏱️
1 022 tests    990 ✔️ 32 💤 0 ❌
2 471 runs  2 398 ✔️ 73 💤 0 ❌

Results for commit 5bf8403.

@cpuguy83
Copy link
Copy Markdown
Member Author

@mxpv No, CI.yml just collects the files as build artifacts those are still useful.

@mxpv mxpv merged commit dda530a into containerd:master Apr 15, 2021
@cpuguy83 cpuguy83 deleted the remove_junit_processor branch April 15, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants