Skip to content

fix(windows): create debug npipe failure#5357

Merged
estesp merged 1 commit intocontainerd:masterfrom
thxCode:support_windows_debug
Apr 14, 2021
Merged

fix(windows): create debug npipe failure#5357
estesp merged 1 commit intocontainerd:masterfrom
thxCode:support_windows_debug

Conversation

@thxCode
Copy link
Copy Markdown
Contributor

@thxCode thxCode commented Apr 14, 2021

fix #5356

@k8s-ci-robot
Copy link
Copy Markdown

Hi @thxCode. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thxCode thxCode force-pushed the support_windows_debug branch from 975492a to 898336a Compare April 14, 2021 07:53
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2021

Build succeeded.

@thxCode
Copy link
Copy Markdown
Contributor Author

thxCode commented Apr 14, 2021

@AkihiroSuda @dvrkps PTAL

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Apr 14, 2021

@thxCode thanks for contribution. would you use real name in signoff ? thanks

@thxCode thxCode force-pushed the support_windows_debug branch from 898336a to 2de38a9 Compare April 14, 2021 09:33
@thxCode
Copy link
Copy Markdown
Contributor Author

thxCode commented Apr 14, 2021

@fuweid updated

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 14, 2021

Build succeeded.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Apr 14, 2021

default:                 Message: "failed to pull and unpack image \"docker.io/library/busybox:1.28\": failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/busybox/manifests/sha256:141c253bc4c3fd0a201d32dc1f493bcf3fff003b6df416dea4f41046e0f37d47: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit",

oops cc @AkihiroSuda and @thaJeztah

@AkihiroSuda
Copy link
Copy Markdown
Member

https://github.com/orgs/stargz-containers/packages provides mirror for well-known images. (*-org: plain mirror, *-esgz: eStargz)

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Apr 14, 2021

Other mirrors:

https://gist.github.com/y0ngb1n/7e8f16af3242c7815e7ca2f0833d3ea6

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit c02081f into containerd:master Apr 14, 2021
@thxCode thxCode deleted the support_windows_debug branch April 15, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows] failed to enable debugging npipe

5 participants