go.mod: github.com/Microsoft/go-winio v0.4.17#5350
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Apr 14, 2021
Merged
go.mod: github.com/Microsoft/go-winio v0.4.17#5350dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan merged 1 commit intocontainerd:masterfrom
Conversation
no code changes as this is the same commit, but now tagged: microsoft/go-winio@5516f17...v0.4.17 Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
14 tasks
|
Build succeeded.
|
kzys
approved these changes
Apr 13, 2021
Member
|
Looks like none of the code actually used by containerd changed, thus no vendor changes? |
Member
Author
Correct; we were already on the commit that was tagged, so this only updates the go.mod to match the tag instead of the commit / pseudo version. One motivation for tagged versions is that distro packagers usually will only use tagged versions; which can lead to obscure errors / issues that may not be in "upstream" (this repository). in this case they would likely have downgraded the dependency to v0.4.16 |
dmcgowan
approved these changes
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #5345
no code changes as this is the same commit, but now tagged:
microsoft/go-winio@5516f17...v0.4.17