Skip to content

go.mod: github.com/containerd/imgcrypt v1.1.1#5349

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
thaJeztah:use_tagged_imgcrypt
Apr 14, 2021
Merged

go.mod: github.com/containerd/imgcrypt v1.1.1#5349
dmcgowan merged 1 commit intocontainerd:masterfrom
thaJeztah:use_tagged_imgcrypt

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Apr 13, 2021

relates to #5345

No code changes other than an updated changelog, and updating to
the tagged v1.1.1:

diff: containerd/imgcrypt@0bed51b...v1.1.1

@thaJeztah
go.mod: github.com/containerd/imgcrypt v1.1.1
d478676 
No code changes other than an updated changelog, and updating to
the tagged v1.1.1:

diff: containerd/imgcrypt@0bed51b...v1.1.1

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 13, 2021

@dmcgowan @dims PTAL

@thaJeztah thaJeztah mentioned this pull request Apr 13, 2021
Closed
14 tasks
dims
dims approved these changes Apr 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Zyqsempai
Zyqsempai approved these changes Apr 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 13, 2021

Build succeeded.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 13, 2021

Looks like some (networking?) failures to download layers from eastus.data.mcr.microsoft.com:

    log_hook.go:40: time="2021-04-13T21:57:15.584198900Z" level=debug msg="do request" func="docker.(*request).do" file="D:/a/containerd/containerd/src/github.com/containerd/containerd/remotes/docker/resolver.go:536" digest="sha256:ea84579f6cd5b58fe78732be37450bd188c8923de3a2062664f3992861449b5c" mediatype=application/vnd.docker.image.rootfs.foreign.diff.tar.gzip request.header.accept="application/vnd.docker.image.rootfs.foreign.diff.tar.gzip, */*" request.header.user-agent=containerd/1.5.0-rc.1+unknown request.method=GET size=101340157 url="https://mcr.microsoft.com/v2/windows/nanoserver/blobs/sha256:ea84579f6cd5b58fe78732be37450bd188c8923de3a2062664f3992861449b5c"
    client_test.go:461: failed to copy: httpReadSeeker: failed open: failed to do request: Get "https://eastus.data.mcr.microsoft.com/aba285c624a04409823b708c7a50e7b9-jttfjm99vo//docker/registry/v2/blobs/sha256/ea/ea84579f6cd5b58fe78732be37450bd188c8923de3a2062664f3992861449b5c/data?P1=1618352087&P2=1&P3=1&P4=bFnGzY6kqmKcrZnR5etsK6OKIGecvBY3od27IboP4rM%3D&se=2021-04-13T22%3A14%3A47Z&sig=p%2FTKdL1v46KQDl8L5BpJkSgmp%2BIV1a04t7ytA0IdRqY%3D&sp=r&spr=https&sr=b&sv=2016-05-31&regid=aba285c624a04409823b708c7a50e7b9": stream error: stream ID 9; CANCEL
--- FAIL: TestImagePullWithConcurrencyLimit (440.46s)
...

    log_hook.go:40: time="2021-04-13T22:04:43.685153900Z" level=debug msg="do request" func="docker.(*request).do" file="D:/a/containerd/containerd/src/github.com/containerd/containerd/remotes/docker/resolver.go:536" digest="sha256:ea84579f6cd5b58fe78732be37450bd188c8923de3a2062664f3992861449b5c" mediatype=application/vnd.docker.image.rootfs.foreign.diff.tar.gzip request.header.accept="application/vnd.docker.image.rootfs.foreign.diff.tar.gzip, */*" request.header.user-agent=containerd/1.5.0-rc.1+unknown request.method=GET size=101340157 url="https://mcr.microsoft.com/v2/windows/nanoserver/blobs/sha256:ea84579f6cd5b58fe78732be37450bd188c8923de3a2062664f3992861449b5c"
    convert_test.go:50: failed to copy: httpReadSeeker: failed open: failed to do request: Get "https://eastus.data.mcr.microsoft.com/aba285c624a04409823b708c7a50e7b9-jttfjm99vo//docker/registry/v2/blobs/sha256/ea/ea84579f6cd5b58fe78732be37450bd188c8923de3a2062664f3992861449b5c/data?P1=1618352387&P2=1&P3=1&P4=24%2BF2MAQIE26YuVe%2FoE5gjCFNU2xiXDnB%2BBaV%2BaGSQw%3D&se=2021-04-13T22%3A19%3A47Z&sig=K%2BWt9inB4bYb8tmZQOBg4q%2FCdC5ATl07ADxNFSxxpho%3D&sp=r&spr=https&sr=b&sv=2016-05-31&regid=aba285c624a04409823b708c7a50e7b9": stream error: stream ID 11; CANCEL
--- FAIL: TestConvert (0.18s)

...
    log_hook.go:40: time="2021-04-13T22:04:43.825260900Z" level=debug msg="do request" func="docker.(*request).do" file="D:/a/containerd/containerd/src/github.com/containerd/containerd/remotes/docker/resolver.go:536" digest="sha256:ea84579f6cd5b58fe78732be37450bd188c8923de3a2062664f3992861449b5c" mediatype=application/vnd.docker.image.rootfs.foreign.diff.tar.gzip request.header.accept="application/vnd.docker.image.rootfs.foreign.diff.tar.gzip, */*" request.header.user-agent=containerd/1.5.0-rc.1+unknown request.method=GET size=101340157 url="https://mcr.microsoft.com/v2/windows/nanoserver/blobs/sha256:ea84579f6cd5b58fe78732be37450bd188c8923de3a2062664f3992861449b5c"
    export_test.go:46: failed to copy: httpReadSeeker: failed open: failed to do request: Get "https://eastus.data.mcr.microsoft.com/aba285c624a04409823b708c7a50e7b9-jttfjm99vo//docker/registry/v2/blobs/sha256/ea/ea84579f6cd5b58fe78732be37450bd188c8923de3a2062664f3992861449b5c/data?P1=1618352387&P2=1&P3=1&P4=24%2BF2MAQIE26YuVe%2FoE5gjCFNU2xiXDnB%2BBaV%2BaGSQw%3D&se=2021-04-13T22%3A19%3A47Z&sig=K%2BWt9inB4bYb8tmZQOBg4q%2FCdC5ATl07ADxNFSxxpho%3D&sp=r&spr=https&sr=b&sv=2016-05-31&regid=aba285c624a04409823b708c7a50e7b9": stream error: stream ID 13; CANCEL
--- FAIL: TestExport (0.12s)

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Apr 13, 2021

close/reopen to kick CI for a new run

@thaJeztah thaJeztah closed this Apr 13, 2021
@thaJeztah thaJeztah reopened this Apr 13, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 13, 2021

Build succeeded.

@dmcgowan dmcgowan merged commit 06dcac5 into containerd:master Apr 14, 2021
@thaJeztah thaJeztah deleted the use_tagged_imgcrypt branch April 14, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims dims approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

+1 more reviewer

@Zyqsempai Zyqsempai Zyqsempai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @dims @dmcgowan @Zyqsempai