Skip to content

address recent runtimes config confusion#5342

Merged
estesp merged 1 commit intocontainerd:masterfrom
mikebrow:improve-error-out-for-bad-config
Apr 13, 2021
Merged

address recent runtimes config confusion#5342
estesp merged 1 commit intocontainerd:masterfrom
mikebrow:improve-error-out-for-bad-config

Conversation

@mikebrow
Copy link
Copy Markdown
Member

the following config issue
https://github.com/kubernetes/kubernetes/pull/100992/files

shows we needed more help in the error messaging

Signed-off-by: Mike Brown [email protected]

@mikebrow mikebrow requested a review from dims April 12, 2021 18:56
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 12, 2021

Build succeeded.

@mikebrow mikebrow force-pushed the improve-error-out-for-bad-config branch from 9db183b to 4ab3aef Compare April 12, 2021 19:21
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 12, 2021

Build succeeded.

@mikebrow mikebrow force-pushed the improve-error-out-for-bad-config branch from 4ab3aef to 8a04bd0 Compare April 12, 2021 20:33
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Apr 12, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 68ee827 into containerd:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants