Switch all our tests to version 2 of config.toml#5335
Merged
AkihiroSuda merged 2 commits intocontainerd:masterfrom Apr 12, 2021
Merged
Switch all our tests to version 2 of config.toml#5335AkihiroSuda merged 2 commits intocontainerd:masterfrom
AkihiroSuda merged 2 commits intocontainerd:masterfrom
Conversation
|
Build succeeded.
|
dims
force-pushed
the
drop-support-for-version-1
branch
from
fb8c892 to
17b3e6f
Compare
|
Build succeeded.
|
dims
force-pushed
the
drop-support-for-version-1
branch
3 times, most recently
from
e68865a to
44a98a7
Compare
Member
|
This shouldn't happen until containerd v2.0 IMO. Not for v1.5, at least. |
|
Build succeeded.
|
dims
force-pushed
the
drop-support-for-version-1
branch
from
44a98a7 to
fcc052b
Compare
|
Build succeeded.
|
dims
force-pushed
the
drop-support-for-version-1
branch
from
fcc052b to
04b704e
Compare
|
Build succeeded.
|
dims
force-pushed
the
drop-support-for-version-1
branch
from
04b704e to
2eabd28
Compare
|
Build succeeded.
|
dims
force-pushed
the
drop-support-for-version-1
branch
from
2eabd28 to
4848fa6
Compare
|
Build succeeded.
|
dims
force-pushed
the
drop-support-for-version-1
branch
from
4848fa6 to
e032cc1
Compare
|
Build succeeded.
|
dims
force-pushed
the
drop-support-for-version-1
branch
from
e032cc1 to
2e4bc20
Compare
dims
changed the title
|
Build succeeded.
|
AkihiroSuda
reviewed
Apr 12, 2021
dims
force-pushed
the
drop-support-for-version-1
branch
from
2e4bc20 to
aeda2a9
Compare
AkihiroSuda
approved these changes
Apr 12, 2021
|
Build succeeded.
|
Also warn when someone uses version 1 Signed-off-by: Davanum Srinivas <[email protected]>
dims
force-pushed
the
drop-support-for-version-1
branch
from
aeda2a9 to
9ad0879
Compare
Signed-off-by: Davanum Srinivas <[email protected]>
|
Build succeeded.
|
kzys
approved these changes
Apr 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are telling folks to switch to version
2, so we should do this ourselves as well :)Signed-off-by: Davanum Srinivas [email protected]