Hi @hakman. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 54s (non-voting)

@hakman for changes to the release script, can you push the change to your local fork and link the successful action run and release.

If github actions is supporting arm64 now, then we need to get that into CI and the nightly first though. We won't release on platforms which aren't validated through our automated tests.

@dmcgowan I hack tested the release script changes on my fork here https://github.com/hakman/containerd/releases/tag/x1.5.0-test.11.

I can understand the policy of not releasing untested builds, but GitHub actions seems set on not providing different architectures than amd64. One option would be self-hosted runners but that is not ideal.

@dmcgowan just for clarity (and I learned this recently when I was digging deeper on the openlab setup): we do run the non-integration tests on arm64 but not integration or CRI: https://github.com/containerd/containerd/blob/master/.zuul/playbooks/containerd-build/run.yaml#L18

We might be able to just add the integration run there; we have gone back and forth on self-hosted runners, but so far I think the barrier is time and attention to get all that setup and working properly.

@hakman Could you resolve the conflicts? I'm going to add /ok-to-test to kick off additional tests after that.

@hakman Could you resolve the conflicts? I'm going to add /ok-to-test to kick off additional tests after that.

Done. Thanks.

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 52s (non-voting)

/ok-to-test

@hakman @AkihiroSuda @estesp i added another job to the openlab harness and added a few things in #5406

There are a few failures:

[dims@dims-a02 12:05] ~/Downloads ⟩ rg FAIL job-output.txt
1746:2021-04-22 15:22:34.877770 | ubuntu-xenial-arm64-openlab | --- FAIL: TestShimDoesNotLeakPipes (0.00s)
2739:2021-04-22 15:26:12.675748 | ubuntu-xenial-arm64-openlab | FAIL
6622:2021-04-22 15:26:12.873622 | ubuntu-xenial-arm64-openlab | FAIL	github.com/containerd/containerd/integration/client	246.714s
6922:2021-04-22 15:26:55.544728 | ubuntu-xenial-arm64-openlab | --- FAIL: TestShimDoesNotLeakPipes (0.00s)
7889:2021-04-22 15:30:35.438553 | ubuntu-xenial-arm64-openlab | FAIL
11895:2021-04-22 15:30:35.584531 | ubuntu-xenial-arm64-openlab | FAIL	github.com/containerd/containerd/integration/client	239.227s
12174:2021-04-22 15:34:49.003349 | ubuntu-xenial-arm64-openlab | --- FAIL: TestVolumeCopyUp (6.36s)
12187:2021-04-22 15:34:55.705727 | ubuntu-xenial-arm64-openlab | --- FAIL: TestVolumeOwnership (6.70s)
12188:2021-04-22 15:34:55.705799 | ubuntu-xenial-arm64-openlab | FAIL

The logs are here:
https://logs.openlabtesting.org/logs/06/5406/34aac4e3d16576da9b00a3c56f40abdfce9b8c58/check/containerd-integration-test-arm64/8dae2a4/

The dashboard is here:
http://status.openlabtesting.org/builds?project=containerd%2Fcontainerd#

We are doing another release candidate early this week, if the testing can be fixed and get this into the rc, then we can include it in 1.5

Once we land #5421 and #5423 we should be all set to land this after those. There's a small hiccup on openlab that is being worked on here theopenlab/openlab#728

Oh, if you want to see a good CI run for ARM64, it's here - #5418 (comment)

Thanks everyone, especially @dims for adding and fixing the testing.
Do you want me to cherry-pick or rebase this one more time to run the tests?

recheck

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 21s (non-voting)
• containerd-test-arm64 : SUCCESS in 5m 28s (non-voting)
• containerd-integration-test-arm64 : SUCCESS in 22m 39s (non-voting)

@dmcgowan now we are ready for shipping ARM64 :)